HealthIntersections / fhirserver

Reference Implementation Server for the FHIR Specification
Other
171 stars 56 forks source link

URLs in search result Bundle.link.url are invalid #194

Open lawley opened 1 year ago

lawley commented 1 year ago

I am getting this back for in a search's Bundle.link:

    "link": [
        {
            "relation": "self"
        },
        {
            "relation": "first",
            "url": "&search-offset=0&_count=20"
        },
        {
            "relation": "next",
            "url": "&search-offset=20&_count=20"
        },
        {
            "relation": "last",
            "url": "&search-offset=80&_count=20"
        }
    ],

which is causing a whole pile of problems for my client.

these are not valid relative URLs since their query part must start with '?' (https://url.spec.whatwg.org/#relative-url-string) if they did start with '?' then that would destroy all the original query parameters (i.e., from the Search request: https://tx.fhir.org/r4/ConceptMap?_format=json)

Furthermore, the links from https://tx.fhir.org/r4/ConceptMap?url:below=http://hl7.org&_format=json look like:

    "link": [
        {
            "relation": "self",
            "url": "below=http://hl7.org"
        },
        {
            "relation": "first",
            "url": "below=http://hl7.org&search-offset=0&_count=20"
        },
        {
            "relation": "next",
            "url": "below=http://hl7.org&search-offset=20&_count=20"
        },
        {
            "relation": "last",
            "url": "below=http://hl7.org&search-offset=80&_count=20"
        }
    ],