search

Healthlane-Technologies / Zango

Django meta-framework for building enterprise-ready custom business applications 💼 ✨
https://zango.dev
Other
235 stars 51 forks source link

Pre-commit and ruff configuration #340

Closed DevilsAutumn closed 1 month ago

DevilsAutumn commented 2 months ago

closes #204

deepakdinesh1123 commented 2 months ago

@DevilsAutumn can you check if there is a pre-commit hook or any way to make sure that secrets and keys are not committed?

DevilsAutumn commented 2 months ago

@DevilsAutumn can you check if there is a pre-commit hook or any way to make sure that secrets and keys are not committed?

Added https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#detect-private-key

kc-diabeat commented 2 months ago

@DevilsAutumn How are we installing the pre-commit package? Don't see it in the requirements.txt file?

DevilsAutumn commented 2 months ago

@DevilsAutumn How are we installing the pre-commit package? Don't see it in the requirements.txt file?

My bad, I forgot to add it in requirements.txt. Added now.

deepakdinesh1123 commented 1 month ago

@DevilsAutumn can we use Interrogate to check if docstrings are added to methods?

DevilsAutumn commented 1 month ago

@DevilsAutumn can we use Interrogate to check if docstrings are added to methods?

Sure!

kc-diabeat commented 1 month ago

The build artifact is available in the artifact section here. You can download it and place the build file under backend/src/zango/assets/app_panel/js for local testing and verification.

deepakdinesh1123 commented 1 month ago

@DevilsAutumn Please exclude migrations folder from pre-commit and add docs on how to setup and use pre-commit in the contribution doc

kc-diabeat commented 1 month ago

The build artifact is available in the artifact section here. You can download it and place the build file under backend/src/zango/assets/app_panel/js for local testing and verification.

shahharsh176 commented 1 month ago

@DevilsAutumn Can we revert the changes made in frontend folder ?

kc-diabeat commented 1 month ago

The build artifact is available in the artifact section here. You can download it and place the build file under backend/src/zango/assets/app_panel/js for local testing and verification.

kc-diabeat commented 1 month ago

The build artifact is available in the artifact section here. You can download it and place the build file under backend/src/zango/assets/app_panel/js for local testing and verification.

DevilsAutumn commented 1 month ago

@DevilsAutumn Can we revert the changes made in frontend folder ?

Done!