Yanrishatum
commented
1 year ago A bit of both. The bug described is WebAudio limitation, and I can do nothing about that. And to workaround that, we'd need to use audio worklets if we want proper sound effects (i.e. implement pitch shift manually). However that causes another issue: worklets require separate JS file as isolated context, and Heaps build system (if we can call it that) does not support having a separate .js file dedicated to audio processing. In short: Current solution is best I could do. In order to fix that we'd have to add worklet support to web driver and implement effects like pitch shift manually.
To elaborate on the bug comment: I have no way to catch the moment when pitch is applied, and that value directly affects how much time said 128 samples are taking up. That throws queue timing completely off. I.e. I queue sound chunk A, then chunk B, while chunk A is being played. But then user changed pitch, causing chunk A to take longer to play. I can estimate current sample somewhat accurately when that happens, and requeue chunk B at correct timing, but because it's a K-rate parameter that timing is not accurate, because if pitch was changed at sample 1, we'll have 127 sample error between chunk A and chunk B. It sure would be NICE if WebAudio had queue system that does not depend on manual timing and would allow us to just feed sequential audio data. But what can we do. It's JS.
zommerfelds
Hi,
I wanted to implement a nice pitch effect on a loop with
hxd.snd.effect.Pitch, where de pitch value depends on some game interaction. However, the result is unusable sound skipping. I think this is due to this code:https://github.com/HeapsIO/heaps/blob/8f7f439116692013b4d9182acb633ba56283dabf/hxd/snd/webaudio/AudioTypes.hx#L52-L53
So I guess it was intended for simplicity. A question though: is this a Web API limitation or just a Heaps implementation issue?