Closed AdamSteffanick closed 9 years ago
Hi Adam, In line 143 you used the rend attribute in the title element. We have not been using the rend attribute there, only in the title element in the header. It's not wrong, but it's also not consistent with the other poems. Should we discuss at today's meeting? I haven't pulled in your changes yet. Ramona
Sounds like a good opportunity to talk standards.
Thank you, Adam
On Fri, Nov 13, 2015 at 11:51 AM Ramona notifications@github.com wrote:
Hi Adam, In line 143 you used the rend attribute in the title element. We have not been using the rend attribute there, only in the title element in the header. It's not wrong, but it's also not consistent with the other poems. Should we discuss at today's meeting? I haven't pulled in your changes yet. Ramona
— Reply to this email directly or view it on GitHub https://github.com/HeardLibrary/corpus-baudelaire/pull/120#issuecomment-156500123 .
That's what I'm thinking! Ramona
Sent from my iPhone
On Nov 13, 2015, at 11:55 AM, Adam Steffanick notifications@github.com wrote:
Sounds like a good opportunity to talk standards.
Thank you, Adam
On Fri, Nov 13, 2015 at 11:51 AM Ramona notifications@github.com wrote:
Hi Adam, In line 143 you used the rend attribute in the title element. We have not been using the rend attribute there, only in the title element in the header. It's not wrong, but it's also not consistent with the other poems. Should we discuss at today's meeting? I haven't pulled in your changes yet. Ramona
— Reply to this email directly or view it on GitHub https://github.com/HeardLibrary/corpus-baudelaire/pull/120#issuecomment-156500123 .
— Reply to this email directly or view it on GitHub.
Critical Apparatus