search

HeartfulnessInstitute / event-summary-bot

Default Fulfillment code in Dialogflow's Inline Editor
Apache License 2.0
1 stars 0 forks source link

Date and City related fixes #3

Closed saibaggins closed 5 years ago

saibaggins commented 5 years ago

Fixed an issue with DialogFlow assuming year 2020 when the year is not explicitly mentioned and also fixed mapping between old city names and new city names like Bangalore and Bengaluru

icyphox commented 5 years ago

Just found time to look at this. LGTM.
Although the hard coded switch case seems a little hacky :)

saibaggins commented 5 years ago

Agreed waiting for the star devs to free up to clean up the cities & dates :)

karthikmuralidharan commented 5 years ago

@saibaggins should we take the approach discussed today regarding combined entities for cities and centres? I would assume that this approach would not be needed then.

saibaggins commented 5 years ago

@saibaggins should we take the approach discussed today regarding combined entities for cities and centres? I would assume that this approach would not be needed then.

@karthikmuralidharan If you're referring to the changes that @Sundararam is working on, yes, we should do that. The changes I committed were interim to support the ongoing testing.

BTW the entities approach will not work, because training the entities for each of the spellings is a nightmare. We can discuss more.