search

HearthSim / HSTracker

A deck tracker and deck manager for Hearthstone on macOS
https://hsreplay.net/downloads/
MIT License
1.18k stars 177 forks source link

Multi-desktop support for battlegrounds #1224

Closed chao2zhang closed 3 years ago

chao2zhang commented 3 years ago

I have a second desktop at the left of my desktop. Battleground tier overlay and tier detail overlay follow the HS window at m second desktop, but the bobs panel and battle details linger on the main desktop.

It seems that we should remove max(0, ...) to consider this scenario. https://github.com/HearthSim/HSTracker/blob/d2eeb74193151195d146eacd57ca86569f533eca/HSTracker/Core/SizeHelper.swift#L371 https://github.com/HearthSim/HSTracker/blob/d2eeb74193151195d146eacd57ca86569f533eca/HSTracker/Core/SizeHelper.swift#L389

fmoraes74 commented 3 years ago

@chao2zhang Thanks for your contribution. I cannot accept the pull request unless you have a CLA in place. @beheh can help you with that. Seems like a simple fix anyway.

I really appreciate anybody who can contribute fixes and improvements.

beheh commented 3 years ago

@chao2zhang This looks great, thank you! Sorry if this seems annoying for such a small change, but we require the CLA for any change. However it's only required a single time, and then you can freely contribute in future.

To proceed, I've added you to the following repository: https://github.com/HearthSim/cla/invitations

Please clone it, read the README and follow the instructions. As soon as we've merged your PR there, we'll proceed here and you can freely contribute. Thanks!

fmoraes74 commented 3 years ago

Merged the fix in, it will in be 1.9.5 release.

Thanks for the contribution!