HearthSim / HSTracker

A deck tracker and deck manager for Hearthstone on macOS
https://hsreplay.net/downloads/
MIT License
1.18k stars 177 forks source link

Mercs Tasks List Not Showing Mac OS 12.1 (M1 Chipset) #1243

Closed dneighbors closed 2 years ago

dneighbors commented 2 years ago

Describe the bug Tasks for Mercs used to show. After battle.net upgrade, Alterac Valley upgrade and HS Tracker upgrade it has stopped working. It shows the widget but is not populating with any content.

Have re-installed HS Tracker. Have restarted Battle.Net, Hearthstone and HS Tracker. Have tried rebooting.

To Reproduce Steps to Reproduce

Game mode

Expected behavior Expect to see a list of all Tasks from campfire visitors and path towards progression for them after each game.

Screenshots Video highlighting issue.

Version (please complete the following information): 2.0.5 (2397)

Additional context Apple M1 Chip Mac OS 12.1

Log file hstracker.log

Deck code N/A

fmoraes74 commented 2 years ago

In the video, I don't see you hover over the Tasks button. You need to mouse over the button for the task list to show. Note that if you have a disconnect during a Mercenaries game, the Task list will only work after you have visited the main camp.

fmoraes74 commented 2 years ago

I have seen a few cases where this happens but I haven't really investigated what causes it. It usually fixes itself if you restart HS and HST (one, the other or both)

dneighbors commented 2 years ago

I hovered as well as clicked. I have restarted HS/HST independently and together as well as rebooted. Issue still occurs on 2.0.7 (2403).. Commits on Dec 3rd, Dec 5th and Dec 7th. changed some logic about when to show and load this data. That aligns with when the issue started occurring. I was traveling on the 5th and didn't update until the 8th, so not sure which of the 3. My guess is "show flavor text on hover

fmoraes74 commented 2 years ago

That commit is for the overlay during a match. The tasks list is implemented on a different class which was not involved in that change you quoted.

If you run the Console application and filter by HSTracker, do you see error messages saying it couldn't read the mercenaries task data?

Also, do you have the preference checked to show the mercenary task data under Preferences->Mercenaries->Shows Tasks panel while in Mercenaries mode ?

dneighbors commented 2 years ago

If I have battle.net open and then start HSTRacker. Then launch hearthstone. Then open "mercenaries" village this is the output from command version of HSTracker:

2021-12-23 15:06:34.624 HSTracker[86104:3970946] NSWindow does not support nonactivating panel styleMask 0x80 2021-12-23 15:06:38.887 HSTracker[86104:3970946] Warning: Column selection is not supported in view-based table and outline views (<NSTableView: 0x7f8aeaeea800>). 2021-12-23 15:07:11.239 HSTracker[86104:3971051] Error while reading reward track data: RewardTrackModel can't be found

Attached is preferences setting: Screen Shot 2021-12-23 at 3 00 43 PM

dneighbors commented 2 years ago

2.0.9 seems to have fixed this.

fmoraes74 commented 2 years ago

2.0.9 seems to have fixed this.

Ok, wonder if this is related to the minimum version requirement then. I didn't touch any Mercenaries code. I will close this issue for now.

dneighbors commented 2 years ago

@fmoraes74 okay I figured out the issue. It wasn't 2.0.9 that fixed it. I play on a MacBook with an external monitor. If I have hearthstone/hstracker open in the MacBook screen it works just fine. If I open both on external monitor it does not work. Which is really bizarre, but at least now I can replicate it working and not working every time.

fmoraes74 commented 2 years ago

@dneighbors so it is not showing up on the external monitor? I will try that sometime this week and fix it. It is usually a simple fix in the code. I am reopening so that I can track it.

fmoraes74 commented 2 years ago

@dneighbors Is this still an issue or can we close it? I haven't seen the issue even on an external monitor, so I want to double check before closing.

fmoraes74 commented 2 years ago

Closing for lack of updates. If this still happens on latest version, please reopen.