Visual TIER7 in BG

[3ndr1ck]

Describe the bug I have a 34" screen and i use it on 3440x1440 in 100Hz

If i used BG in 3440x1440 the tier7 are visual break (i see only the 3th hero Tier7 minion stats, i can't see Heroes stats and th 4th Tier7 minion stats). I must use in 1920x1080 in windows mode (full screen same bug).

To Reproduce Steps to reproduce the behavior:

1. Go to BG mode, wait heroes choose
2. See Visual error

Game mode

• [ ] Standard
• [ ] Wild
• [ ] Classic
• [ ] Arena
• [x] Battlegrounds
• [ ] Duels
• [ ] Mercenaries
• [ ] Tavern Brawl
• [ ] Dungeon Run/Book of Heroes/Book of Mercenaries
• [ ] Single Player

Expected behavior Everytime i lunch a BG game in 3440x1440 (dauft resolution on my screen), i can have all TIER7 information during the HEROES choosing

Screenshots see files

Version (please complete the following information): 2.3.10 but same 2.3.8/9

Log file see files; i start a logfile only with 3440x1440 fullscreen

screenshot

log file hstracker.log

i think is BattlegroundsHeroPicking.updateScaling(): who bug with the resolution

Regards

[fmoraes74]

Unfortunately I don't know what's wrong as I haven't seen anything similar in my attempts to recreate. I tested with an external monitor which has a similar resolution but it is working for me. If someone can compile the code and try to debug and figure out the issue, it would be really welcome. I will attempt a recreate with different resolutions but I haven't found the culprit. Someone from the team has the same issue and the debug code added around updateScaling didn't reveal anything obvious. With Xcode, it should bd possible to inspect the view hierarchy when the issue happens and see what the problem might be.

[3ndr1ck]

For information i have a mac mini A1 with APPLE maybe this can modify sommething with their own graphical architecture

[fmoraes74]

I have an Intel Mac laptop. I wondered if this is specific to M1 or non laptops but I have no way to debug at the moment.

[fmoraes74]

How is your Display scaling setting?

Is it More Space ? Can you test with Default ?

[3ndr1ck]

Hi,

I’m yet in default mode

Regards

Le 19 mars 2023 à 21:36, Francisco Moraes @.***> a écrit :

How is your Display scaling setting?

https://user-images.githubusercontent.com/7808154/226207477-bfaeb677-7834-4e28-a63d-c109be6ae066.png Is it More Space ? Can you test with Default ?

— Reply to this email directly, view it on GitHub https://github.com/HearthSim/HSTracker/issues/1303#issuecomment-1475390064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY3RWOLFS746CQQZWCRCRB3W45U6VANCNFSM6AAAAAAV42HQ3Y. You are receiving this because you authored the thread.

[fmoraes74]

I believe I have a fix but I'd like someone else to try it out. Let me know if you are interested. I will provide you a link to a test version

[3ndr1ck]

Hi,

Yes I can try your fix

regards

Le 20 mars 2023 à 15:11, Francisco Moraes @.***> a écrit :

I believe I have a fix but I'd like someone else to try it out. Let me know if you are interested. I will provide you a link to a test version

— Reply to this email directly, view it on GitHub https://github.com/HearthSim/HSTracker/issues/1303#issuecomment-1476307485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY3RWOLWV5JAXBIESNPAKY3W5BQQ3ANCNFSM6AAAAAAV42HQ3Y. You are receiving this because you authored the thread.

[fmoraes74]

@3ndr1ck Here's a test version: https://drive.google.com/file/d/1AZIRfekx9SBwR1-7WXlQhcmnfNc2yxaJ/view?usp=share_link

This is a private build, so it hasn't gone through the notarization, so you may get some pop ups. Let me know if this works.

[3ndr1ck]

Hi,

Very good new the bug for TIER 7 is ok

Only one visual bug for me but not very important for the game

Now i can play in full screen with TIER7 information

Regards

[fmoraes74]

Thanks for confirming the fix. Can you open a separate issue for that? I am not sure yet about that fix but I will see if there is an easy way to get it right. At least I know that I need to use the highest resolution to recreate these issues. It also shows that scaling of multiple overlays may need to be improved in the future.

[3ndr1ck]

Ok i prepare another ticketRegards Envoyé de mon iPhoneLe 21 mars 2023 à 14:35, Francisco Moraes @.***> a écrit : Thanks for confirming the fix. Can you open a separate issue for that? I am not sure yet about that fix but I will see if there is an easy way to get it right. At least I know that I need to use the highest resolution to recreate these issues. It also shows that scaling of multiple overlays may need to be improved in the future.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

[fmoraes74]

Fixed by change https://github.com/HearthSim/HSTracker/commit/6bd65ea4695fdb1acfdb028ab446ad3513f5b333

[fmoraes74]

Fixed officially in version 2.3.12.