search

HearthSim / HSTracker

A deck tracker and deck manager for Hearthstone on macOS
https://hsreplay.net/downloads/
MIT License
1.19k stars 177 forks source link

HSTracker crashed in M1 pro mac #1349

Closed flytam closed 1 month ago

flytam commented 1 month ago

Describe the bug Crash frequently when in the game

To Reproduce Open hearthstone and open HSTracker Observe the crashes

Game mode

Expected behavior A clear and concise description of what you expected to happen.

Screenshots Try to compile the source code on local is the error here, because not a professional ios development so not sure what caused it

image

Version (please complete the following information): Important: please specify the version of HSTracker that you are using

Additional context Add any other context about the problem here.

Log file Attach the hstracker.log file found under /Users/<userid>/Library/Logs/HSTracker/ directory (or use the Help->Open log directory) hstracker.log

Deck code If the problem happens with a specific deck, please include the deck code used.

fmoraes74 commented 1 month ago

Thanks for the report. I will try to get it fixed as soon as I can recreate it. I had no issues with BG or some other game modes but I didn't test standard.

flytam commented 1 month ago

Submitted a MR to fix it and worked on my side

fmoraes74 commented 1 month ago

Seems like this was probably triggered by an opponent discover. I have a fix that I will test a little bit but if you are willing to try it as well, let me know @flytam

flytam commented 1 month ago

sure. i'm willing to try it

fmoraes74 commented 1 month ago

Here's the change if you don't mind testing without your fix.

https://github.com/HearthSim/HSTracker/commit/9c4acd6729a3c39bb07cde75e3a8bec940b4b940

DazzaButch commented 1 month ago

I'm having issues on M1 Pro machine. Any standard/ranked game the app just crashes straight out. Battlegrounds seems fine.

hstracker.log hstracker.older.log

.older.log is from yesterday. the other one is today. I redownloaded and installed fresh from website and still get issues.

fmoraes74 commented 1 month ago

I released version 3.0.6 which should fix the problem. Please let me know

flytam commented 1 month ago

tried using 3.0.6 and seems no crash yet, thanks!

DazzaButch commented 1 month ago

Another log from 3.0.5 which crashed about 6 mins ago. hstracker.log

Happened when i discovered a card Ill update and try 3.0.6 now :D