HearthSim / HSTracker

A deck tracker and deck manager for Hearthstone on macOS
https://hsreplay.net/downloads/
MIT License
1.19k stars 177 forks source link

Cannot manually upload replays (from file .hdtreplay) #751

Closed skitimo closed 6 years ago

skitimo commented 7 years ago

HStracker (version 0.19) didn't upload some of my games to HSReplay.net automatically, so I tried to upload them manually but still didn't work as I expected.

Is this the way I could manually upload, right?

screen shot 2017-02-14 at 4 36 04 am
ifeherva commented 7 years ago

"still didn't work as I expected" could please elaborate what has happened and what you expected to happen? Thanks!

skitimo commented 7 years ago

When I tried to upload a replay manually by using the above feature (with .hdtreplay file), the result is that either nothing happens or I get this error:

screen shot 2017-02-25 at 2 57 42 am

Ideally, I want to upload my missing replays to HSReplay.net, if this the process succeeds the replays should be added into HSReplay.net server, like

screen shot 2017-02-25 at 3 02 33 am

Thank you so much for taking care of the issue.

zot24 commented 7 years ago

I'm experiencing the same issue some of my match didn't get uploaded to the online system however I can see the file of the replay in the folder, is there anyway to retry the upload?

zot24 commented 7 years ago

I tried to track down the problem looking into the logs ~/Library/Logs/HSTracker and the G/H code.

First of all my version of HSTracker is 0.19.3 (1500)

Second I tried to Load from file as @skitimo mentioned and literally nothing happens I can't even see the error he is seeing and there is no info on the logs at all.

And last mention that so far looks like it does upload all my matches properly to Track-O-Bot as I can see the following logged line from Game.swift#L626 in all my matches:

...
|I|12:09:54.483| Posting match to Track-o-Bot ["result": ["added": ...
|I|12:09:54.745| Fetching https://trackobot.com/profile/results.json?username=MY_USERNAME&token=MY_TOKEN complete
|D|12:09:54.746| post match : {
...

However there are few matches that doesn't have the following lines, which I think it's the bit of the code that upload of the match:

|I|12:09:54.481| Uploading 1544526698113626898 -> ["client_handle": "7975800", "format": 2, "player2": ["deck_id": 1135352251, "stars": 15, "cardback": 18, "rank": 19], "ladder_season": 41, "brawl_season": 91, "scenario_id": 2, "aurora_password": "AURORA_PASSWORD", "spectator_password": "SPECTATOR_PASSWORD", "player1": ["rank": 19, "cardback": 68], "server_ip": "SERVER_IP", "game_handle": "5636854", "match_start": "2017-03-11T11:58:42Z", "resumable": true, "game_type": 2, "server_port": "3724", "server_version": "339777", "build": 17994, "spectator_mode": false, "friendly_player": 2]
|I|12:09:55.081| Fetching https://upload.hsreplay.net/api/v1/replay/upload/request complete
|I|12:09:55.106| 1544526698113626898 upload done: Success

Bear in mind this is my first time looking into Swift code and particularly into this project code, hope this helps to whoever gonna pick this issue

Note: I have obfuscated some data as I wasn't sure it was sensible data

ifeherva commented 6 years ago

Is this issue still happening with the current version?

skitimo commented 6 years ago

No. The current version works great. Thank you for your hard work. :-)

ifeherva commented 6 years ago

Thanks for the feedback.