0.21-beta1: replays not uploading to HSReplay

[bewebste]

This issue is only one I've seen running the new 0.21-beta1 version. Games I've played with the new version don't appear to be uploading their replays to HSReplay.net properly. I did some preliminary digging, and it looks like the .hdtreplay files may be getting truncated somehow, so that they only include the final portion of the game and are missing most of the beginning. If I look at ~/Library/Application Support/HSReplay, the file sizes of the replay files goes way down on April 27th, when I started using the new beta. Some example output from ls -l:

-rw-r--r--  1 bwebster  staff   62452 Apr 26 15:05 2017-04-26 15:05:15-07:00 - Jezebel(Rexxar) vs runningrat(Morgl the Oracle).hdtreplay
-rw-r--r--  1 bwebster  staff   50069 Apr 26 15:13 2017-04-26 15:13:24-07:00 - Jezebel(Rexxar) vs BIG(Anduin Wrynn).hdtreplay
-rw-r--r--  1 bwebster  staff   45228 Apr 26 15:56 2017-04-26 15:56:11-07:00 - Jezebel(Rexxar) vs silver(Anduin Wrynn).hdtreplay
-rw-r--r--  1 bwebster  staff   67902 Apr 26 17:49 2017-04-26 17:49:48-07:00 - Jezebel(Maiev Shadowsong) vs behemoth(Uther Lightbringer).hdtreplay
-rw-r--r--  1 bwebster  staff   49812 Apr 26 18:17 2017-04-26 18:17:35-07:00 - Jezebel(Maiev Shadowsong) vs Roycen(Garrosh Hellscream).hdtreplay
-rw-r--r--  1 bwebster  staff   77301 Apr 27 08:15 2017-04-27 08:15:11-07:00 - Jezebel(Maiev Shadowsong) vs SneakyBeaky(Anduin Wrynn).hdtreplay
-rw-r--r--  1 bwebster  staff  105949 Apr 27 08:34 2017-04-27 08:34:26-07:00 - Jezebel(Maiev Shadowsong) vs MicMichael(Thrall).hdtreplay
-rw-r--r--  1 bwebster  staff   72758 Apr 27 10:57 2017-04-27 10:57:24-07:00 - Jezebel(Rexxar) vs Darkhippo(Jaina Proudmoore).hdtreplay
-rw-r--r--  1 bwebster  staff     298 Apr 27 12:58 2017-04-27 12:58:55-07:00 - Jezebel(Uther Lightbringer) vs Kikkijikki(Jaina Proudmoore).hdtreplay
-rw-r--r--  1 bwebster  staff     295 Apr 27 13:08 2017-04-27 13:08:07-07:00 - Jezebel(Uther Lightbringer) vs Xoma(Rexxar).hdtreplay
-rw-r--r--  1 bwebster  staff    2312 Apr 27 14:36 2017-04-27 14:36:02-07:00 - Jezebel(Uther Lightbringer) vs SebTek(Rexxar).hdtreplay
-rw-r--r--  1 bwebster  staff     128 Apr 27 15:44 2017-04-27 15:44:50-07:00 - Jezebel(Uther Lightbringer) vs Rasmus(Uther Lightbringer).hdtreplay
-rw-r--r--  1 bwebster  staff     267 Apr 27 16:42 2017-04-27 16:42:13-07:00 - Jezebel(Uther Lightbringer) vs STRIZH(Valeera Sanguinar).hdtreplay

You'll see that starting with the match at Apr 27 12:58 2017-04-27 12:58:55, the file sizes drop from 50-100 KB down to 1-4 KB. If I open one of the replay files, it appears to have only the final 1-2 turns of the game present in the replay file. I've attached one sample file from my latest game. The Giant Mastadon play you see at the very start of the file was the final card my opponent played on their turn before I won the next turn. (Equality!)

2017-05-02 11:23:10-07:00 - Jezebel(Uther Lightbringer) vs RomarioGross(Jaina Proudmoore).hdtreplay.txt

[bmichotte]

@ifeherva is working on it