search

HearthSim / HSTracker

A deck tracker and deck manager for Hearthstone on macOS
https://hsreplay.net/downloads/
MIT License
1.18k stars 177 forks source link

Arena score fails when it contains a non-numeric character #830

Closed marlonrichert closed 7 years ago

marlonrichert commented 7 years ago

Sprint is actually rated as "117^" for Rogue at http://thelightforge.com/TierList, but shows up in HSTracker as "0". screen shot 2017-05-10 at 16 52 49

marlonrichert commented 7 years ago

Another example: Fan of Knives is actually "132^", but shows up as "0". screen shot 2017-05-10 at 16 57 42

ifeherva commented 7 years ago

Thanks, I will look into it. Please crop the uploaded images a bit :)

bmichotte commented 7 years ago

The error is here : https://github.com/HearthSim/HSTracker/blob/master/HSTracker/ArenaHelper/ArenaWatcher.swift#L66

We should exclude all non numbers chars before cast it as Int... will correct it later today

marlonrichert commented 7 years ago

@ifeherva: Cropped. :)

marlonrichert commented 7 years ago

@bmichotte, while you're at it, might be good to show the original "^" symbol or some other marker to indicate that "this card is bad in multiples".