search

HearthSim / Hearthstone-Collection-Tracker

A plugin for Hearthstone Deck Tracker that allows to keep track on pack sets
33 stars 14 forks source link

Kobolds and Catacombs expansion update #33

Closed itayt closed 6 years ago

itayt commented 6 years ago

Added an updater for Kobolds and Catacombs (KaC) expansion. Compiled (VS Community 2017) and tested locally, seems to work fine.

judge2020 commented 6 years ago

Hey, sorry for the general delays regarding this project. I've been busy with other things so time to review these PR's, as well as fix the filtering issue, was limited.

By the looks of it, your visual studio is reporting it's VS2013 and for some reason removed the references to HearthDb at https://github.com/HearthSim/Hearthstone-Collection-Tracker/pull/33/files#diff-e706daab5c2912d19537d342f2086bedL192. I appreciate the help here and will be using your code. I'll just implement it myself and reference you to prevent some incompatibilities shown here.

itayt commented 6 years ago

Sounds great, this isn't really my jam I was just keen to use the updated plugin!