search

HearthSim / Hearthstone-Collection-Tracker

A plugin for Hearthstone Deck Tracker that allows to keep track on pack sets
33 stars 14 forks source link

Resolved QuickConverter error #36

Closed CTristan closed 6 years ago

CTristan commented 6 years ago

After the merge I attempted to load the resulting DLL. Whenever I tried to open the plugin it gave this error: "System.IO.FileNotFoundException: Could not load file or assembly 'QuickConverter, Version=1.2.5.0, Culture=neutral, PublicKeyToken=9c892aa7bc2af2cf' or one of its dependencies. The system cannot find the file specified."

This fix removes the QuickConverter Nuget package and replaces it with a MultiBinding and some modified/added converters. I'm not sure why the error is cropping up now but this resolves it.

I had used QuickConverter to make a MultiBinding on the visibility for the desired amount boxes in collection editor since I was doing multiple checks in it (Only display if we are using the Desired Cards feature and NOT using the Use Decks For Desired feature). It seems to not include the package in the assembly when built so we won't be able to continue using it.

I modified the VisibilityConverter to allow for converting either a single boolean or combining multiple booleans into one Visibility value. I also created an InverseBooleanConverter because bindings don't have a way to check for the opposite value and I needed to check if we're not using the "Use Desired Decks" option. These two changes combined with the MultiBinding gives us the same end result as the QuickConverter binding did.

judge2020 commented 6 years ago

If possible, could you also remove it from the packages.config?

CTristan commented 6 years ago

Ah sorry, forgot about that. Removed it from the project's nuget packages.