HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.76k stars 1.12k forks source link

Game stats enhancement: notes field #170

Closed MyopicCat closed 10 years ago

MyopicCat commented 10 years ago

Very pleasant surprise to see game stats being added to the tracker, I didn't even know you were working on it. I already track my stats using HearthstoneTracker, but Hearthstone Deck Tracker (isn't it annoying that the names are so similar?) is already very close to replacing the other program completely. The most important thing missing for me is a notes field, so I can jot down what type of deck the opponent had. Since HearthstoneTracker can filter on the notes field, this makes it possible to check your record vs "zoo", "handlock", "naxx zoo" etc. (I also take a note any unusual legendaries my opponent is playing.)

So, any chance for similar capability here? Either something to add notes after the game, or even better an in-game text box somewhere on the left side (since notes usually concern the opponent's deck).

azeier commented 10 years ago

There should be no problem adding that. The biggest "issue" right now would be that the note would be outside of the default view, so you would have to scroll to the right.

azeier commented 10 years ago

How about this? http://imgur.com/a/sCWhZ

I'm probably gonna shorten the data string a little bit still.

MyopicCat commented 10 years ago

Some thoughts:

All of the above are just my own preferences, feel free to disagree!

azeier commented 10 years ago

Alright, I think I'm on to something here. No more scrolling for warlock/warrior, more space for notes. screenshot 2014-08-11 10 17 59

As for your last point, while I agree it was a bit cleaner before, I really like being able to see the winrates directly in there. I would make it an option but that might be a bit tricky.

azeier commented 10 years ago

Added with v0.4.3

MyopicCat commented 10 years ago

I take back what I said about the stats table, this version looks really nice. Please also consider filtering on notes, even if it's way down on your priorities list!

An idea for game details: would it be possible to record attacks and other game events in the log? Even if it becomes too messy to display in the tracker, then it would be possible to reconstruct the entire game. Maybe your tracker version 23.0 could feature an entire game replayer? :) Or someone else could code one using your log files ...

azeier commented 10 years ago

Filtering notes.. just have a combobox with all the notes you used so far and if you e.g. choose "zoolock", then if filter all the games for which the note is exactly "zoolock" or contains "zoolock"? That's gonna be a very long list if you don't limit yourself to just a few notes.

Sadly, the logs don't contain any information about attacks (or I haven't found them yet but I doubt that), The only way of getting that information is via TCP or memory. Both of those violate the TOS.

MyopicCat commented 10 years ago

Too bad about the attacks. A combobox wouldn't work for the type of notes I take, because I jot down both hand type and special cards (e.g. "ramp druid: ragnaros + ysera"). This creates far too many combinations for a combobox. I think a text box would be best, with a contains-type filter. So "zoo" would match zoo, zoolock, and naxx zoo.

azeier commented 10 years ago

That.. should have been the obvious solution.. yes..

Question now is: where do I put that :/

MyopicCat commented 10 years ago

Well, you may want to filter on almost any column, so how about putting the comboboxes and textboxes right above the corresponding columns? I think they should be near the stats that they affect. You could also consider deleting the "edit note" button and putting the note textbox near the top of the game details screen.

azeier commented 10 years ago

Added note filter with v0.4.8