search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.61k stars 1.11k forks source link

Deck Version Issue #2791

Open ascejim opened 7 years ago

ascejim commented 7 years ago

Been using deck tracker for a while. Very annoying thing happening now.

If you make a version change to an existing deck, rather than imbedding the changes, it creates a copy of the deck, thus littering my deck list with every version change I make.

I would prefer that it go back to the default behavior of just imbedding the changes within the original list. It's a mess.

I looked through every setting. Am I missing something?

SNiLD commented 7 years ago

I noticed this too and it's very annoying. In addition it causes the tracker to guess wrong decks in the middle of the matches. I think I'm using beta version, but can't be sure because it's loaded by the new patcher (clicking help shows version 1.0.5 but I have Check BETA updates checked).

I have included log file with the issue: log_392016-20152.txt At the start you can see the deck edit version update and in the end you can see the match where the deck detection failed.

ascejim commented 7 years ago

I have the problem without beta updates checked. So it must be something in the current build.

azeier commented 7 years ago

@SNiLD That doesn't sound like the same issue. You are editing decks in HDT I think? Try edit decks in game and import them via IMPORT > FROM GAME: CONSTRUCTED - you can also turn on auto importing in that menu.

@ascejim I'm not really sure. Do you have auto importing and updating enabled under options (advanced) > tracker > importing? Please reproduce it and then upload the log - see here: https://github.com/HearthSim/Hearthstone-Deck-Tracker/wiki/Reporting-Issues

azeier commented 7 years ago

I think I found the issue - or at least one related to importing. It seems changes are imported to decks with better matching cards rather than matching IDs.

@ascejim see if you are still having issues with this build: https://github.com/azeier/HDT-Test/releases/tag/1.0.5.29-4

Note: it might still import some decks as new ones once due to the previous issues but should no longer in subsequent imports.

ascejim commented 7 years ago

Yes I am able to duplicate with the other version as well.

I have also uninstalled and deleted all data under the roaming profile, reinstalled and was still able to duplicate it with brand new deck.

I also lost the ability to double click a deck in the deck list to automatically edit it. I don't know if that might also be related.

Thanks for the help :)

hdt_log.txt

azeier commented 7 years ago

Oh, this happens only when manually edit decks in HDT? Yeah that is definitely not inteded.

I thought were importing decks from the game. Then do the same thing I suggested for SNiLD above:

Try edit decks in game and import them via IMPORT > FROM GAME: CONSTRUCTED - you can also turn on auto importing in that menu.

azeier commented 7 years ago

Alright, I found and fixed the issue!

You should be ok if you use automatic importing for now as mentioned above (I'd recommend it either way ;)).

azeier commented 7 years ago

Also, for manually saving as new versions: you can just delete the previous older one (lower/no version number). That's what HDT is currently failing to do.

ascejim commented 7 years ago

Will do. Thanks for looking into to it.

tinnvec commented 7 years ago

Also, for manually saving as new versions: you can just delete the previous older one (lower/no version number). That's what HDT is currently failing to do.

Doing this causes the entire deck to be deleted on hearthstats (all versions). Afterwards, right-clicking the deck and selecting 'open hearthstats' goes to the main landing page with an error about not being able to find the deck.

The only way I've been able to setup the link between the deck and hearthstats again is to clone the entire deck and delete whichever one yields the error page on hearthstats. This also has the nasty side effect of erasing that deck's history.

azeier commented 7 years ago

@tinnvec turn off HEARTHSTATS > AUTO DELETE DECKS and AUTO DELETE GAMES for now

tinnvec commented 7 years ago

@azeier Thanks, had nearly forgotten about those settings

ghost commented 7 years ago

I have importing from hearthstone switched off, and I'm seeing this behaviour since a couple days ago.

Whenever I manually edit a deck in HDT, it creates a copy of the deck with both the old version, and the new version in it. The old copy is still there, without the new version.

I only noticed it when it was matching the wrong deck during matches. Is there a way to stop this happening? I'm not going to use the auto-update decks from HS. (I have tried it and found it unreliable.)