HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.72k stars 1.11k forks source link

Overlay doesn't display ingame #3143

Open Baardy opened 7 years ago

Baardy commented 7 years ago

Bug report

Overlay is gone

Expected Behavior

Overlay showing up ingame

Actual Behavior

Overlay never shows up with my deck and my opponents deck ingame or not ingame

azeier commented 7 years ago

Topmost sticking on player windows is good news. See if this build is any better: HDT-1.2.2-overlay-2.zip The overlay should now mimic the exact topmost behavior of those windows.

tom5079 commented 7 years ago

running in administrator mode solved my problem. thanks Discordia.

Dazamin commented 7 years ago

@azeier

See if this build is any better: HDT-1.2.2-overlay-2.zip

The latest build did not fix it, but it did make some difference. Now when you initially start the game, the overlay shows (It didn't before) However if you go to another window and come back it disappears again. This is running HS full screen on one monitor and a browser on a second screen.

EDIT: When running as admin, clicking back after using another window, the overlay disappears and then immediately reappears

azeier commented 7 years ago

Can you confirm the player window stats on top when doing the same thing? (https://github.com/HearthSim/Hearthstone-Deck-Tracker/issues/3143#issuecomment-293176525)

azeier commented 7 years ago

HDT-1.2.2-overlay-3.zip

This one checks natively whether the overlay is topmost ((GetWindowLong(hwnd, GwlExstyle) & WsExTopmost) != 0) and tries to set it several times if it's not.

Please try this and post the HDT log after (see here: https://github.com/HearthSim/Hearthstone-Deck-Tracker/wiki/Reporting-Issues)

rorgier10 commented 7 years ago

The 1.2.2 overlay 3 seems to working fine for now, will try to see if all the settings work. I will update as soon as possible and post de HDT log aswell.

Update: Does not work if you have Hide if HS in background checked on.

Update 2: Here is the log:

dpaste log

Dazamin commented 7 years ago

@azeier

Can you confirm the player window stats on top when doing the same thing? (#3143 (comment))

Player window stats do always stay on top running without admin

Please try this and post the HDT log after

Okay, running this, it seems to work better, I have to disable and reenable an overlay option to get it to show. (I untick and retick always show gold in menu) That seems to hold better when I move to other windows. When I went into my collection it seemed to flash every few seconds and eventually disappeared after flicking between windows for a while and then coming back to HS. Once I close HS I see the gold counter as the bottom layer, behind my taskbar goldoverlay

dpaste log

Dazamin commented 7 years ago

@azeier

Log when running as admin

dpaste log

azeier commented 7 years ago

Thats progress I guess. The flickering in the colletion is probably related to the Collection Tracker plugin erroring a bunch.

azeier commented 7 years ago

Trying two more things:

HDT-1.2.2-overlay-4.zip

See if this improves anything and please post logs again (and upload to dpaste so this stays more readable :) )

rorgier10 commented 7 years ago

The hide HDT while HS is in background now works.

http://dpaste.com/317J13T

azeier commented 7 years ago

Meaning everything works now?

rorgier10 commented 7 years ago

For me it does yes.

Update: Found a weird thing, whenever a match is finished it kinda alt-tabs me out of game for like 3 seconds and then goes back into it. (show the game but also the windows bar and all)

azeier commented 7 years ago

One hopefully last build: 1.2.2-overlay-5.zip

Dropped the child window stuff again, that the only change I can think of that might cause weird behavior. Also don't think it's necessary.

Can I get a few testers on this?

rorgier10 commented 7 years ago

Well it fixed the weid behavior at the end of a game, but now the overlay does not stay active after alt-tabbing out the game. It works just fine when starting the game and playing but as soon as I open another window the whole overlay is gone.

azeier commented 7 years ago

That sounds like the "hide if hearthstone is in background" option is enabled

rorgier10 commented 7 years ago

That is correct.

(so at this moment the overlay 4 works the best for me, i only have to deal with the weird behavior after a match has ended for only like 3 seconds)

ManJelL commented 7 years ago

The latest build fixed it for me. Thank you!

Salviio commented 7 years ago

Same problem as mentionned earlier, i'm trying to dl the latest version. Anyway azeier you are the mvp! thx a lot

Madi921 commented 7 years ago

The latest version still no good for me.

ManJelL commented 7 years ago

Weird. I noticed that the card tooltips on the decklist dont apear ingame.

Salviio commented 7 years ago

Last version seems to work fine for me. Still have to enable and then disable a random option to make it appear but it stays on HS screen. Thx azeier

Kamamura commented 7 years ago

The latest version 5 is a partial solution for me. When I start HS, the overlay does not appear, and is rendered "below" the main output as before. However when I switch focus to HDT and then back to HS, the overlay is suddenly visible and works without problems until I close HS.

So not perfect, but much better than before.

azeier commented 7 years ago

HDT-1.2.2-overlay-6.zip

Any chance this fixes the startup issue?

rorgier10 commented 7 years ago

The overlay 6 only works with Hide if HS in background disabled. When I enable this it sits behind hearthstone again and we are back to the beginning for me atleast. Version 4 is the one I use now, because it works the best for me at this moment.

Is there any way to fix the end game like disabling the thing what caused the weird behavior? (the child window thing) Because I feel the child window is what fixes it for me.

azeier commented 7 years ago

That's exactly what 5 did.

azeier commented 7 years ago

Can you logs from 6? With and without hide in background enabled.

rorgier10 commented 7 years ago

5 got completely rid of the child window you said. And the thing is, the child window is what I think is fixing the problem for me, the only thing is, is that it is causing the weird behavior at the end of the game. my question was: is there a way so you could implement the child window and fix something at the end of the game (so i can alt tab my game and have the Hide if HS in background)

azeier commented 7 years ago

Not sure probably not. I still don't know why the bug happens in the first place or why any of this (somewhat) fixes it.

rorgier10 commented 7 years ago

After some fiddling with the options 6 seems to be working for me aswell now. Here are the logs still: With Hide if HS in background enabled: http://dpaste.com/20S30TN With Hide if HS in background disabled: http://dpaste.com/1Q8NFS5

azeier commented 7 years ago

Thanks. What's "some fiddling with the options" exactly?

rorgier10 commented 7 years ago

haha uhm well, I turned a lot of things on and off and ended up with the same settings, but now everything was working... sorry that this does not help at all

MonsieurChaunce commented 7 years ago

The latest build worked for me on fixing whatever the problem was, I'll send logs when I'm home from work tonight.

azeier commented 7 years ago

Are you guys using any other overlay apps (like the heartharena client)? If so, does turning it off help? Doesn't seem to be the issue

rorgier10 commented 7 years ago

I am using graveyard, heartharena and trouble at the mill. Also using msi afterburner overlay. I have tried turning them off but it seems not to matter. However I think turning those off and back on again made overlay 6 work for me.( Not 100% sure)

TristanCP commented 7 years ago

I've just run HDT from HDT-1.2.2-overlay-6.zip and it fixes the overlay problem for me (Windows 7). Before I had tried to fully reinstall HS and HDT with no success. The workaround was not rly working as well since the "player" and "opponent" windows would not stay on top.

azeier commented 7 years ago

HDT-1.2.2-overlay-8.zip

This should activate the overlay window when the game is started. See if this helps with it being hidden on startup.

rorgier10 commented 7 years ago

Now it does not work anymore when Hide when HS in background is active.

Version 6 was working fine, even on the startup.

azeier commented 7 years ago

Are you sure it's not just random? None of the changes should cause that.

Dazamin commented 7 years ago

@azeier So for me it appears to work properly now with one exception. As I previously said, being in the collection with collection manager plugin running (this is now the new plugin which causes no errors) causes the overlay to flicker and then be hidden when you return to the HS window, not sure if that is to do with the plugin or HDT, anyway am attaching a paste of my log. Will update if I find any other instances where overlay gets hidden again.

http://dpaste.com/3N2YV86

rorgier10 commented 7 years ago

@azeier Well you might be right. after trying version 8 a couple of times. It somehow works. The same thing with 6. The first use is not working, restarting HDT and everything works fine like it should. No idea what is causing that first time to not work though.

MalygosQ commented 7 years ago

I have rebooted the computer (I do not think this is related to the HDT). And for some reason I began to work fine with HDT, but there were no updates!

azeier commented 7 years ago

This should be improved (maybe even fixed in some cases) now with v1.2.3

MalygosQ commented 7 years ago

THANK YOU FOR UPDATES, Again does not show HDT in the game

azeier commented 7 years ago

I'm out of ideas then.

rorgier10 commented 7 years ago

the overlay 5,6 and 8 I got working after using overlay 4. the 1.2.3 update does not work even after that... Still when Hide if HS in backrgound is active.

azeier commented 7 years ago

v1.2.3 has the exact same implementation as 6 does.

rorgier10 commented 7 years ago

Then I have no clue about what is causing it to not work the first time, but everytime after a while the version does work... (Still don't have the 1.2.3 working, now running on version 6 which is working)

ManJelL commented 7 years ago

Version 1.2.3 works fine for me. But only when "Hide if HS in Background is not activated. Also, the card tooltips which apear when you hover over cards in your decklist or over secrets dont appear anymore.

BertZZ commented 7 years ago

Same issue, Running as Administrator fixed it