search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.75k stars 1.12k forks source link

Tray Icon Signature changes with every update #3632

Open OzanKurt opened 6 years ago

OzanKurt commented 6 years ago

Image

You can not imagine how annoying it is to do the same thing over and over again for each update.

judge2020 commented 6 years ago

Relevant squirrel issue: https://github.com/Squirrel/Squirrel.Windows/issues/863, I'm not sure if this is something fixable in HDT itself.

OzanKurt commented 6 years ago

So what can we do to fix this?

azeier commented 6 years ago

Actually - I'm not sure whether this fixes it, but I removed the version number from the icon text for now. I suppose there is a chance of that being the problem.

OzanKurt commented 6 years ago

Yeah that might have been the case. Windows is retarded enough to mark them as different applications. :+1:

ceceita commented 6 years ago

in the judge2020 link , user WolfspiritM wrote

I figured out what the reason is: https://github.com/Squirrel/Squirrel.Windows/blob/master/src/Squirrel/TrayHelper.cs#L106 This checks for the exe in the package being inside the path of the TrayIcon, however the Path is converted to lowercase a few lines above. So if the exe does have uppercase letters it's not recognized and it jumps to "keepItem". My temporary fix is to rename my .exe to lowercase, but I think that should be fixed.

so i think the fix is to call it hearthstone deck tracker instead of Hearthstone Deck Tracker , it's a bit bad ...

azeier commented 6 years ago

Renaming the exe has all sorts of implications, definitely can't do that.

OzanKurt commented 6 years ago

image

It seems to work now with the new update!

OzanKurt commented 6 years ago

image

We still have the same problem even if the signature is same. ;/

riQQ commented 3 years ago

@OzanKurt does this work now? This was possibly fixed with the fix for #3666.