search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.69k stars 1.11k forks source link

Deck Tracker not Launching Hearthstone #3708

Closed JiveArtifact closed 6 years ago

JiveArtifact commented 6 years ago

Bug report

Expected Behavior

I expected to press the "Launch Hearthstone" button and have the Hearthstone app open with the deck tracker active.

Actual Behavior

Nothing happened - the "Start Hearthstone" button was gray for a second but then returned to its original state without the Hearthstone app having been opened.

Steps to reproduce behavior

Just clicking on start Hearthstone. I've tried the other steps for it not working, such as changing the path, but none of it has worked so far. -

CLJunge commented 6 years ago

Same for me. Debugged HDT, no errors. Maybe a Battle.net issue?

azeier commented 6 years ago

Looks like blizzard changed something about the procotols. Don't have time to investigate right now, but this is the command that is no longer working: https://github.com/HearthSim/Hearthstone-Deck-Tracker/blob/master/Hearthstone%20Deck%20Tracker/Utility/HearthstoneRunner.cs#L52

CLJunge commented 6 years ago

I'll take a look.

azeier commented 6 years ago

The "name" hasn't changed. battlenet://WTCG still opens the hearthstone tab on the launcher.

CLJunge commented 6 years ago

Executing 'Battle.net.exe --exec="WTCG"' launches Hearthstone successfully, but i'm not sure if that's a desired solution since we have to know the installation directory.

azeier commented 6 years ago

Since we can still launch the battle.net client via battlenet:// the easiest fix is probably:

  1. Run battlenet:// (already happens)
  2. Wait for the process (already happens)
  3. Get Battle.net.exe path via the running process
  4. Run <full_path>/Battle.net.exe --exec="WTCG"

I'm not sure how to best work around the Battle.net.beta client though. Is that the same executable?

azeier commented 6 years ago

I guess we actually know whether we find the Battle.net or Battle.net.beta process and thus find the correct executable path regardless. The above approach will work.

CLJunge commented 6 years ago

The command is actually 'Battle.net.exe --exec="launch WTCG"'. Just installed the beta version and the default and beta client are now running under the same name, so that shouldn't be a problem. I'll implement a fix.

azeier commented 6 years ago

Gonna leave this open actually until the release it out, to prevent duplicates.

There should be a release around noon PST tomorrow.

azeier commented 6 years ago

Fixed with v1.6.8