search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.76k stars 1.12k forks source link

Overall stats, stats-recording without selected deck #412

Closed azeier closed 9 years ago

azeier commented 9 years ago

I finally (somewhat) finished this!

Short summary:

Backup your files in "%appdata%/HearthstoneDeckTracker", I don't think this should cause any trouble but who knows. Download here (or just build master) - feedback on this would be much appreciated.

Elitesparkle commented 9 years ago

I've played Arena without a selected deck and the game has been recorded. I didn't test other modes yet but I don't see reason why they shouldn't work.

You should add a class filter for the overall games.

The "Move to other deck" button should make you able to assign a game to no deck.

The following feedbacks are about old things related to this addition.

If, for example, I'm playing an Arena game without a selected deck I can't look at one of my decks list and/or stats because, if I click it, it will change the deck that's loaded on the overlay and used for the current game.

Since we have seasons in Hearthstone, you should change filters from "Last Week/Month/Year" to "This Week/Month/Year". I couldn't check how you managed those filters since I'm new on this software and I have recorded games for this week only. I'm just saying that if I use the week filter, whathever it's the name, at the beginning of a week, I shouldn't see yesteday games. The same should be true about month and year. The names you gave to those filters tell me you didn't manage it this way but, if you did, you should just change the names.

When I don't use a deck, I don't think there is the need to show win rates on top of the decks.

You should show how many games are listed. Maybe at the bottom, near the buttons but on the right side.

The following feedbacks are just litte layout details but maybe you want a feedback about those as well.

In the stats window I'd write "Deck" rather than "Current Deck" so that it doesn't seems like if there are both "Current" and "Deck" tabs.

Also, I think there is enough space to put the games below the second table in the "Overall" tab. I'd put it there and remove "Stats" and "Game" tabs.

In the big table, when a field is empty, I'd write "-" rather than "-%".

Eventually, I'd put the games filter after the note one.

azeier commented 9 years ago

You should add a class filter for the overall games.

I had a lot of filters at some point actually (that being one of them) but I threw them out for now to just get it working. I will probably start adding them back.

If, for example, I'm playing an Arena game without a selected deck I can't look at one of my decks list and/or stats because, if I click it, it will change the deck that's loaded on the overlay and used for the current game.

That's just how it works though, not sure what I could reasonably do about that.

Since we have seasons in Hearthstone, you should change filters from "Last Week/Month/Year" to "This Week/Month/Year". ... The names you gave to those filters tell me you didn't manage it this way but, if you did, you should just change the names.

Currently it's just the last 7, 30 and 365 days of games, but it would make more sense this way, I agree. I'll try to make that work.

When I don't use a deck, I don't think there is the need to show my win rate on top of my deck.

Makes sense, changed that.

In the stats window I'd write "Deck" rather than "Current Deck" so that it doesn't seems like if there are both "Current" and "Deck" tabs.

Changed that as well, looks a bit odd right now but maybe that's just me.

Also, I think there is enough space to put the games below the second table in the "Overall" tab. I'd put it there and remove "Stats" and "Game" tabs.

That's the way I had it at first but after probably an hour of fiddling around with it I gave up. It works perfectly fine as long as the window has a certein height, below that, if the details box is expaneded the games-box just is outside the window. Putting it in a scrollviewer doesn't work either without setting a fixed height for the table (it'll just extend to its max height because the scrollviewer allows it to do so) which then again causes problems if the window exceeds a certain height... yeah..

In the big table, when a field is empty, I'd write "-" rather than "-%".

That does look better, changed.

Eventually, I'd put the games filter after the note one.

Does also look better I guess, not really sure :). Changed for now either way.

Elitesparkle commented 9 years ago

If, for example, I'm playing an Arena game without a selected deck I can't look at one of my decks list and/or stats because, if I click it, it will change the deck that's loaded on the overlay and used for the current game.

That's just how it works though, not sure what I could reasonably do about that.

I know but I wanted to write that anyways.

When I don't use a deck, I don't think there is the need to show my win rate on top of my deck.

Makes sense, changed that.

However I'm not sure about that part. Maybe showing the overall win rate with the class you are using could be fine. The same for the opponent, respectively. If you remove it, just don't cut the opponent class together with the win rate.

azeier commented 9 years ago

Between showing "0-0" and showing nothing, nothing is definitely the better option for now :).

Elitesparkle commented 9 years ago

I was writing that to tell you to keep the opponent class but I removed that part and added a line to my second message.

If you remove it, just don't cut the opponent class together with the win rate.

By the way, I agree.

azeier commented 9 years ago

You mean the "VS Priest:..:" ? That's also based on the current deck iirc so the same applies. I'll probably add an option to show the winrates based on the current class when no deck is selected, though.

Elitesparkle commented 9 years ago

Yes, I mean that, without the numbers.

By the way, it's fine without. It isn't really needed since you can see your opponent class looking at the battlefield. Since it is there just to say that the win rate is related to that class, there is no need to keep it when the numbers aren't there.

midorlo commented 9 years ago

Didnt find anything else, you did a pretty good job :)

azeier commented 9 years ago

Changed 2) and 3) with d9bade7. Good points.

I'm not sure I quite understand your first suggestion though. Do you mean rightclicking a deck should have the same effect as decks > use no deck?

midorlo commented 9 years ago

Exactly :)

azeier commented 9 years ago

That feels a lot better than I expected, done!

azeier commented 9 years ago

Released this with v0.6.0.

I'm gonna close this, open a new issue if you have more suggestions :).

azeier commented 9 years ago

Oh and thanks for the feedback!

midorlo commented 9 years ago

Youre welcome, thanks for being in contact with your users! ;) PS: A new one is one the way, you will love/hate it lol

culinko commented 9 years ago

"@Epix37 clicking a selected deck deselects it (#412)"

Was this function lost with the new deck selection layout?

azeier commented 9 years ago

More removed than lost, but yes. I think being able to select "no deck" via the TRACKER menu and the try icon context menu is fine.