search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.75k stars 1.12k forks source link

Missing card art in battlegrounds #4169

Open LordDrew opened 4 years ago

LordDrew commented 4 years ago

Bug report

With recently updated "last seen board" in BG I can see only minion's frame and stats without actual art. In application's appdata folder "Images/CardPortraits/_inProgress/" there are files with 0 size and there are no images in "Images/CardPortraits/". Looks like they can't be downloaded (see log below). I'm running HDT under Wine, but all other HDT network interactions work fine (like collection uploading). Also there is no problem with loading same picture URLs with a browser or python script, only dectracker can't get them directly.

Log/Screenshots

11:21:12 PM|Info|AssetDownloader.DownloadAsset >> Starting download for CFM_315. 11:21:12 PM|Info|AssetDownloader.DownloadFileAsync >> Waiting to cleanup CFM_315. 11:21:12 PM|Info|AssetDownloader.DownloadAsset >> Starting download for KAR_005. 11:21:12 PM|Info|AssetDownloader.DownloadFileAsync >> Waiting to cleanup KAR_005. 11:21:12 PM|Info|AssetDownloader.DownloadAsset >> Starting download for BGS_119. 11:21:12 PM|Info|AssetDownloader.DownloadFileAsync >> Waiting to cleanup BGS_119. 11:21:12 PM|Info|AssetDownloader.DownloadAsset >> Starting download for BGS_055. 11:21:12 PM|Info|AssetDownloader.DownloadFileAsync >> Waiting to cleanup BGS_055. 11:21:12 PM|Info|AssetDownloader.DownloadAsset >> Starting download for EX1_531. 11:21:12 PM|Info|AssetDownloader.DownloadFileAsync >> Waiting to cleanup EX1_531. 11:21:13 PM|Error|AssetDownloader.DownloadFileAsync >> Unable to download CFM_315: The underlying connection was closed: An unexpected error occurred on a send. 11:21:13 PM|Error|AssetDownloader.DownloadFileAsync >> Unable to download KAR_005: The underlying connection was closed: An unexpected error occurred on a send. 11:21:13 PM|Error|AssetDownloader.DownloadFileAsync >> Unable to download BGS_119: The underlying connection was closed: An unexpected error occurred on a send. 11:21:13 PM|Error|AssetDownloader.DownloadFileAsync >> Unable to download BGS_055: The underlying connection was closed: An unexpected error occurred on a send. 11:21:13 PM|Error|AssetDownloader.DownloadFileAsync >> Unable to download EX1_531: The underlying connection was closed: An unexpected error occurred on a send.

chucklu commented 3 years ago

@LordDrew This should not be a bug, it's a network problem. You might contact your network provider to solve it. C:\Users[username]\AppData\Roaming\HearthstoneDeckTracker\Images

chucklu commented 3 years ago

@azeier @jleclanche Is it possible to show the minion name along with the image? The minion name can be used to recognize the minion even if the minion image load failed.

chucklu commented 3 years ago

@LordDrew The card image seems download from here https://github.com/HearthSim/Hearthstone-Deck-Tracker/blob/5db69b9d7ccc22afa70fce5e4b96443c30804320/Hearthstone%20Deck%20Tracker/Utility/Assets/AssetDownloaders.cs#L22 You might try to access https://art.hearthstonejson.com/v1/256x/DMF_533.jpg to see if your network works well.

LordDrew commented 3 years ago

@chucklu Thank you for your reply!

It's definitely not an issue with my network: card images can be downloaded with browser or curl/wget. I even have written small work-around script in Python that checks for empty files in _inProgress folder and downloads them. I've made some additional research on this issue and it looks like combination of some strict SSL encryption setting on art.hearthstonejson.com, new .Net default settings and the fact that .Net is running under Wine. Collection and replays upload uses different endpoint and that's why it works.

Is there any way to get all the art downloaded beforehand? Or at least maybe it is possible to get the full list or required images? I do not want to spam art.hearthstonejson.com server with requests to find out which IDs are valid and which aren't.

riQQ commented 3 years ago

See #4234

chucklu commented 3 years ago

@azeier @riQQ @jleclanche Found a bug and did a fix, please review this pull request https://github.com/HearthSim/Hearthstone-Deck-Tracker/pull/4239

beheh commented 11 months ago

https://github.com/HearthSim/Hearthstone-Deck-Tracker/pull/4239 was merged a long time ago.

beheh commented 11 months ago

Actually, maybe this is the same as #4234?