Deck import error Lord Jaraxxus

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows

https://hsreplay.net/downloads/

4.61k stars 1.11k forks source link

Deck import error Lord Jaraxxus #4267

Open anonymous555 opened 3 years ago

anonymous555 commented 3 years ago

Importing the following deck code misses Lord Jaraxus. Using the latest version as of today.

### Control Warlock
# Class: Warlock
# Format: Standard
# Year of the Gryphon
#
# 2x (1) Armor Vendor
# 2x (1) Spirit Jailer
# 2x (2) Drain Soul
# 2x (2) Soul Shear
# 2x (3) Hysteria
# 2x (3) Luckysoul Hoarder
# 2x (3) School Spirits
# 1x (3) Tamsin Roame
# 2x (4) Cascading Disaster
# 2x (5) Ogremancer
# 2x (5) Siphon Soul
# 1x (6) Tickatus
# 1x (7) Soulciologist Malicia
# 2x (7) Strongman
# 2x (8) Twisting Nether
# 1x (9) Alexstrasza the Life-Binder
# 1x (9) Lord Jaraxxus
# 1x (10) Y'Shaarj, the Defiler
#
AAECAf0GBs/SA/zeA87hA/LtA7CKBIWgBAysywPM0gPN0gOO1APG3gPm4QP14wP44wOS5AOCoASDoATnoAQA

# To use this deck, copy it to your clipboard and create a new deck in Hearthstone
# Find this deck on https://hsreplay.net/decks/cAiJhTGootJ4uq5w4xjceh/

Bug report

Expected Behavior

Actual Behavior

Steps to reproduce behavior

Log/Screenshots

anonymous555 commented 3 years ago

Here's another example deck

AAECAf0GCM/SA/zeA87hA5boA/LtA6iKBLCKBIWgBAusywPM0gPN0gPG3gPm4QP14wP44wOS5AOCoASDoATnoAQA

mattestes commented 3 years ago

Just wanted to add to this, that I'm having the same issue. Also, when I try to add Jaraxxus manually, it doesn't have the Core Set Hero card version of Lord Jaraxxus, just the Legacy minion version. It seems like it doesn't properly realize that the Hero card version exists.

onewa2403 commented 2 years ago

This is the change that created the issue:

Forged in the Barrens 20.0.0.77662 (2021-03-25): Lord Jaraxxus is now a hero card instead of a minion. Now grants 5 Armor. No longer sets your maximum Health to 15.

Lord Jaraxxus is now the only card that is COLLECTIBLE, an HERO and from the CORE set. The result is that when parsing the list of all cards Lord Jaraxxus is not inserted in the list of collectible ones and thus can not be imported.

See related code: if (card.Collectible && (card.Type != CardType.HERO || card.Set != CardSet.CORE && card.Set != CardSet.HERO_SKINS))

All the others HERO card are from the set Fractured in Alterac Valley: https://playhearthstone.com/en-us/cards?set=standard&type=hero&viewMode=table

This issue is actually related to the repo HearthDB: https://github.com/HearthSim/HearthDb

Behavior after a fix: issue4267

PR: https://github.com/HearthSim/HearthDb/pull/24

anonymous555 commented 2 years ago

Any chance of getting this fixed? Seems like someone already provided a pull request with the fix https://github.com/HearthSim/HearthDb/pull/24