All decks should be imported correctly, and if the player class is not clear, let the player choose.
Actual Behavior
The StringImported.Import function is not importing some decks that contain multiclass cards. Currently, all cards are tied to a single class, even if they can be used by two (like the cards from Scholomance).
For example, Lightning Bloom is internally tagged as a DRUID card, but it can be added to Shaman and Druid decks. When using the StringImporter, it detects both Shaman and Druid classes and returns a null deck, discarding it.
Steps to reproduce behavior
This can be tested using the TestNeutralOnly Test:
Open ParseCardStringTest.cs (in HDTTests > Hearthstone).
Copy the following string from a Shaman deck:
Lightning Bloom x 2\nDevolving Missiles\nLightning Bolt x 2\nNovice Zapper x 2\nPrimordial Studies x 2\nBloodmage Thalnos\nCagematch Custodian x 2\nDiligent Notetaker x 2\nLandslide x 2\nRockbiter Weapon x 2\nInstructor Fireheart\nSerpentshrine Portal x 2\nStormstrike x 2\nDunk Tank x 2\nTorrent x 2\nDoomhammer x 2\nInara Stormcrash\n
Replace the string "Ragnaros the firelord" with the copied above.
Run the test and notice that it fails as the returned deck is null as a result of detecting two different player classes.
Log/Screenshots
Warning|StringImporter.Import >> Could not identify a class for this deck. Found class cards for 2 classes.
Bug report
Expected Behavior
All decks should be imported correctly, and if the player class is not clear, let the player choose.
Actual Behavior
The StringImported.Import function is not importing some decks that contain multiclass cards. Currently, all cards are tied to a single class, even if they can be used by two (like the cards from Scholomance).
For example, Lightning Bloom is internally tagged as a DRUID card, but it can be added to Shaman and Druid decks. When using the StringImporter, it detects both Shaman and Druid classes and returns a null deck, discarding it.
Steps to reproduce behavior
This can be tested using the TestNeutralOnly Test:
Lightning Bloom x 2\nDevolving Missiles\nLightning Bolt x 2\nNovice Zapper x 2\nPrimordial Studies x 2\nBloodmage Thalnos\nCagematch Custodian x 2\nDiligent Notetaker x 2\nLandslide x 2\nRockbiter Weapon x 2\nInstructor Fireheart\nSerpentshrine Portal x 2\nStormstrike x 2\nDunk Tank x 2\nTorrent x 2\nDoomhammer x 2\nInara Stormcrash\nLog/Screenshots
Warning|StringImporter.Import >> Could not identify a class for this deck. Found class cards for 2 classes.