HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.75k stars 1.12k forks source link

Secret Tracker displays disqualified secrets as possible. #4275

Open processingNow opened 3 years ago

processingNow commented 3 years ago

Bug report

Expected Behavior

A user starts off with only 2 of each secret in there deck. If there has played no spell discovery or random secret generation, the tracker should omit secrets that have been revealed twice when a secret is played.

Actual Behavior

When a new secret is played, Secret tracker still displays all secrets available to the class regardless if secrets have been disqualified (2 of that secret have been revealed with no random spell generation)

Steps to reproduce behavior

Play against a class that includes secrets with no random spell/secret generation (paladin).

Log/Screenshots

processingNow commented 3 years ago

Give secrets a possible number of occurrence that resets and increments by 1 each time a spell generation card is played. Keep track of the generated spell and decrement the secrets occurrence accordingly.