Show dust for golden deck, adventure cards and skip uncraftable cards

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows

https://hsreplay.net/downloads/

4.61k stars 1.11k forks source link

Show dust for golden deck, adventure cards and skip uncraftable cards #4277

Closed sgkoishi closed 3 years ago

sgkoishi commented 3 years ago

This PR contains changes:

Add option to include/exclude adventure cards during Deck Screenshot dust calculation
Add option to use golden cards during dust calculation
Update the uncraftable list

Fix #4276

[x] I have read the Contributing Guidelines
[x] I have already signed the CLA

sgkoishi commented 3 years ago

This commit also adds two localization resource key, DeckScreenshot_Label_GoldenDust and DeckScreenshot_Label_Adventure, while the resource file is downloaded from HearthSim/HDT-Localization

azeier commented 3 years ago

1) What's the reason for showing the dust cost for golden cards in the screenshot? It seems rather misleading to me when there is no other indicator on the screenshot about the cost being for golden cards.

I could see that making a lot more sense in this view

2) Adventure cards are not craftable at all, are they? In which case this should not be a setting but they should simply be removed from the dust calculations.

sgkoishi commented 3 years ago

Adventure cards are craftable once moved to the wild, and all adventures are in the wild right now.

For golden cards, would it be better to add another golden icon in addition to the original dust icon?