Fix Reckoning Secret Being Incorrectly Excluded

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows

https://hsreplay.net/downloads/

4.61k stars 1.11k forks source link

Fix Reckoning Secret Being Incorrectly Excluded #4298

Closed reesercollins closed 3 years ago

reesercollins commented 3 years ago

[x] I have read the Contributing Guidelines
[x] I have already signed the CLA

Fixes #4290

Jonysegal commented 3 years ago

Thanks for the pr! Coincidentally I was working on a fix for the same problem, but looking at your approach made me think of some more nuance that this fix needs (eg poisonous, divine shield + poisonous, when certain tags are logged), so I'll work on those and push a fix soon.

Jonysegal commented 3 years ago

After implementing and testing the divine shield and poisonous fixes I tested it and realized reckoning doesn't actually care about poisonous, so that didn't end up mattering. Regardless, fix with a task delay to allow the relevant power lines to appear is here https://github.com/HearthSim/Hearthstone-Deck-Tracker/pull/4299