HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.61k stars 1.11k forks source link

Counterspell not going greyed out on the secret helper #4306

Open Mfunn opened 3 years ago

Mfunn commented 3 years ago

Bug report

Counterspell against mage secret(s) not being greyed out on the secret helper after using a spell in wild.

Expected Behavior

Counterspell icon on the secret helper going greyed out after a spell is used and no secret was activated.

Actual Behavior

Counterspell stays lighten up even after a spell was used against one or more active secrets.

Steps to reproduce behavior

Play against a mage > mage plays one or more secrets > play a spell and mage still has 1 or more active secrets after spell being used > secret helper not showing counterspell being greyed out.

Was played in wild mode, did not test the bug in standard or classic, not sure if bug is simply in all modes or comes from the large wild secret pool or comes from multiple spell secrets interactions ( like mage having counterspell + spellbender / mana bind / netherwind portal ).

notdeshawn commented 3 years ago

also not working in standard.

reesercollins commented 3 years ago

Does this issue happen with Oh My Yogg or just Counterspell?

Looking at the code, I can't imagine why one would work and not the other.

notdeshawn commented 3 years ago

I am not 100% sure but I do remember another secret having the same issue before.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: @.> Sent: June 18, 2021 8:24 PM To: @.> Cc: @.>; @.> Subject: Re: [HearthSim/Hearthstone-Deck-Tracker] Counterspell not going greyed out on the secret helper (#4306)

Does this issue happen with Oh My Yogg or just Counterspell?

Looking at the code, I can't imagine why one would work and not the other.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/HearthSim/Hearthstone-Deck-Tracker/issues/4306#issuecomment-864316623, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUREWGVZDDJK6UXH3WBWW4LTTPIRZANCNFSM465YMEKA.

raviatus commented 3 years ago

Just had the case that Oh My Yogg did not get greyed out in standard

Mfunn commented 3 years ago

update : it is not only counterspell but also manabind and netherwind portal that doesnt grey out as you can see in my screenshot; my bad for not noticing initially @reesercollins

Clipboard2

gitkosta commented 3 years ago

I think this is an issue with spell detection in general. I'm playing a yogg deck and the spell counter always stays at 0, in addition to the already cited issue with spell secrets not greying out.