search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.61k stars 1.11k forks source link

Spell schools not attached to Card object #4421

Closed slicedbread closed 1 year ago

slicedbread commented 1 year ago

Expected Behavior

I'm trying to write a plugin for multicaster and I need access to played cards' spell schools

Actual Behavior

The data isnt mapped from hearthdb

I've actually made a branch locally to rectify this but I can't find how to contact the team for this repo to request the ability to make a branch on remote. I reached out on discord and haven't had any luck. I recognize this is probably not the best place to make this request but if I could be given permission to make a PR I'd appreciate it.

beheh commented 1 year ago

Hello, thanks for wanting to contribute! The standard way to do this on GitHub is for you to create a fork of this repository, push your branch there, and then open a PR here. Here's a help article from GitHub with all the steps. Let me know here if you have any more questions, otherwise I'll see you over in your PR!

slicedbread commented 1 year ago

Awesome, I didnt realize I was supposed to fork, but that makes sense thanks.

The link to that agreement doesnt seem to work, can you provide me the CLA to sign?

image
beheh commented 1 year ago

I've sent you an invite!

slicedbread commented 1 year ago

signature PR'd!

slicedbread commented 1 year ago

https://github.com/HearthSim/Hearthstone-Deck-Tracker/pull/4423