Mapped SpellSchool to HDT/Card.cs from hearthbCard

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows

https://hsreplay.net/downloads/

4.65k stars 1.11k forks source link

Mapped SpellSchool to HDT/Card.cs from hearthbCard #4423

Closed slicedbread closed 2 years ago

slicedbread commented 2 years ago

[x] I have read the Contributing Guidelines
[x] I have already signed the CLA

This PR adds spell schools to Card.cs for use in a multicaster plugin

azeier commented 2 years ago

Can you make that a pass-through prop instead? Like e.g. Card.CardSet or Card.TechLevel. No need for all the constructor changes. See https://github.com/HearthSim/Hearthstone-Deck-Tracker/blob/master/Hearthstone%20Deck%20Tracker/Hearthstone/Card.cs#L233-L243

beheh commented 2 years ago

CLA has been signed.

slicedbread commented 2 years ago

Can you make that a pass-through prop instead? Like e.g. Card.CardSet or Card.TechLevel. No need for all the constructor changes. See https://github.com/HearthSim/Hearthstone-Deck-Tracker/blob/master/Hearthstone%20Deck%20Tracker/Hearthstone/Card.cs#L233-L243

updated, this is definitely cleaner, thanks for the suggestion

azeier commented 2 years ago

👍🏻 Looks good