search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.61k stars 1.11k forks source link

Bob's Buddy simulation result opens by itself when updating opponent's hand #4485

Closed gabrieljablonski closed 10 months ago

gabrieljablonski commented 10 months ago

Bug report

Expected Behavior

When the option "Show results during combat phase" is disabled, the combat simulation results should only be shown after combat is over, or when clicking the overlay.

Actual Behavior

When the card "Free-Flying Feathermane" is summoned by opponent during combat (the new tier-3 beast), the combat simulation results overlay opens by itself. It may happen in other situations as well (maybe Bassgill?), but this is the one I've actually noticed.

Log/Screenshots

https://github.com/HearthSim/Hearthstone-Deck-Tracker/assets/21102974/dfb759fd-7c4f-40a9-92d2-5f501b4a944b

Additional context

Very likely something to do with changes from commit dba5c8d. Pretty sure it's this line.

beheh commented 10 months ago

Thanks for the report! This has been fixed by https://github.com/HearthSim/Hearthstone-Deck-Tracker/commit/a5897612467a33fa5c26867df4306ad4c94f45ea and will go live out in an HDT release shortly.