search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.76k stars 1.12k forks source link

Game Stats now in TRIPLICATE! #679

Closed GaelicSmash closed 9 years ago

GaelicSmash commented 9 years ago

As per title, since the last update every match is recorded in triplicate when I view the stats. (On looking into it further it seems its just when I select "Overall" & "Games" together).

azeier commented 9 years ago

Does that happen with all decks?

GaelicSmash commented 9 years ago

I think ive sussed out what was happening. As I changed a card in the deck, id then save it as V1.1 etc. Then when playing with the new deck it recorded in stats for each copy of that deck, inspite of only playing with

  1. Im assuming this was what was causing it as I did have 3 versions of the same deck (original & 1.1,1.2). As soon as I deleted the original & 1.1 I noticed its only recording 1 lot in "Stats" again, like its supposed to.

Btw, thanks LOADS for your reply & this awesome app dude. Seriously wicked little tool !

On Wed, Feb 11, 2015 at 9:31 PM, Epix notifications@github.com wrote:

Does that happen with all decks?

— Reply to this email directly or view it on GitHub https://github.com/Epix37/Hearthstone-Deck-Tracker/issues/679#issuecomment-73969032 .

dvide commented 9 years ago

Sounds like it might be related to the 0.9.5 fix.

@GaelicSmash Did you use the 'SAVE AS NEW (v1.0)' option to create these decks? I tested that out on 0.9.4 and whenever you had a game assigned to one of the decks it would also assign it to the other, so they would appear twice in Overall Games.

@Epix37 To replicate: Download 0.9.4 and use a fresh config. Import Natural Remedies and save the deck. Edit Natural Remedies and call it 'Natural Remedies 2' and then use SAVE AS NEW (can also change some cards if you want but it doesn't matter). Edit Natural Remedies again and call it 'Natural Remedies 3' and then click SAVE AS NEW again. Now manually create a game assigned to Natural Remedies and it should show up triple in Overall Games, one for each deck.

GaelicSmash commented 9 years ago

No I used "Save as V1.1, 1.2 etc. On 12 Feb 2015 22:18, "Jack Whitehead" notifications@github.com wrote:

Sounds like it might be related to the 0.9.5 fix.

@GaelicSmash https://github.com/GaelicSmash Did you use the 'SAVE AS NEW (v1.0)' option to create these decks? I tested that out on 0.9.4 and whenever you had a game assigned to one of the decks it would also assign it to the other, so they would appear twice in Overall Games.

@Epix37 https://github.com/Epix37 To replicate: Download 0.9.4 and use a fresh config. Import Natural Remedies http://www.hearthpwn.com/decks/140918-natural-remedies and save the deck. Edit Natural Remedies and call it 'Natural Remedies 2' and then use SAVE AS NEW (can also change some cards if you want but it doesn't matter). Edit Natural Remedies again and call it 'Natural Remedies 3' and then click SAVE AS NEW again. Now manually create a game assigned to Natural Remedies and it should show up triple in Overall Games, one for each deck.

— Reply to this email directly or view it on GitHub https://github.com/Epix37/Hearthstone-Deck-Tracker/issues/679#issuecomment-74165536 .

dvide commented 9 years ago

@GaelicSmash How did you delete v1.0 and v1.1 then? I thought you couldn't delete deck versions?

GaelicSmash commented 9 years ago

??? Yeah, deleted 1.1 & 1.2. That's the only way I found out the "Triplicate" issue in my op was related to these versions On 13 Feb 2015 00:58, "Jack Whitehead" notifications@github.com wrote:

@GaelicSmash https://github.com/GaelicSmash How did you delete v1.0 and v1.1 then? I thought you couldn't delete deck versions?

— Reply to this email directly or view it on GitHub https://github.com/Epix37/Hearthstone-Deck-Tracker/issues/679#issuecomment-74186444 .

dvide commented 9 years ago

Sorry, I'm just trying to understand. You said originally: '... I did have 3 versions of the same deck (original & 1.1,1.2). As soon as I deleted the original & 1.1 ...'

That to me implies you deleted 1.0 and 1.1. Now you're saying you deleted 1.1 and 1.2. But I still don't understand how that's possible because as far as I'm aware, there's no function yet to delete a version of a deck, only the whole thing (all 3 versions). Did you delete the whole thing and then recreate one of the versions as a brand new deck?

dvide commented 9 years ago

Ok just want to make sure of something. Sorry if you feel like you've already answered this, but are you saying you had your 3 versions of the same deck set up like this?

untitled2

Or like this? (Where you choose which version you want to play from the dropdown list.)

untitled

GaelicSmash commented 9 years ago

The top picture On 13 Feb 2015 01:27, "Jack Whitehead" notifications@github.com wrote:

Ok just want to make sure of something. Are you saying you had your 3 versions of the same deck set up like this?

[image: untitled2] https://cloud.githubusercontent.com/assets/180188/6180597/2fc35af4-b31f-11e4-9811-7aa08a30b705.jpg

Or like this (where you choose which version you want to play from the dropdown list):

[image: untitled] https://cloud.githubusercontent.com/assets/180188/6180595/29cec44e-b31f-11e4-8eda-a2d466e25572.jpg

— Reply to this email directly or view it on GitHub https://github.com/Epix37/Hearthstone-Deck-Tracker/issues/679#issuecomment-74189242 .

dvide commented 9 years ago

Okay thanks, that's helpful. I think this bug has already been fixed then with 0.9.5. It might still affect decks created prior to 0.9.5 though, if they were saved at the time using this button:

untitled