search

HearthSim / Hearthstone-Deck-Tracker

A deck tracker and deck manager for Hearthstone on Windows
https://hsreplay.net/downloads/
4.7k stars 1.11k forks source link

Minor Bug - Deck name not being set when exporting to Hearthstone #70

Closed michaelb7k closed 10 years ago

michaelb7k commented 10 years ago

Description:- At some non-native, fullscreen resolutions the deck name is not set on exporting a deck to Hearthstone. Steps to reproduce:- -Set a non-native fullscreen resolution for Hearthstone -Export a deck to Hearthstone Expected result:- The name of the exported deck would be set along with it's cards. Observed result:- The name is sometimes not set due auto-clicker not selecting the name input field. Reproduction rate:- At low, non-native fullscreen resolutions (especially wildly different non-native aspect ratio) occurs 8/10 times.

michaelb7k commented 10 years ago

If the tracker were to know the current resolution the game was running at, this would help to improve the auto-clicker.

Current resolution the game is running at:- %AppData%\Local\Blizzard\Hearthstone\options.txt

azeier commented 10 years ago

I just tried it multiple times with all resolutions, deck name was set 100% of the time. Is this maybe happening with your ClientRect change?

michaelb7k commented 10 years ago

It was occuring occasionally before with the old WindowRect to.

michaelb7k commented 10 years ago

The deck name text box is known to be buggy - floating around the screen etc.

This bug occurs when the text box first has focus, before exporting a deck. On focus, the text box strangely reduces in size, thus the auto-clicker then misses clicking on it by 4-5px.

This may only occur on non-standard dpi settings.

An obscure bug that may not be worth fixing.

azeier commented 10 years ago

Good to know, thanks. And I agree, problably not worth it.