search

HearthSim / Joust

🍿 Hearthstone replays in your browser.
https://hearthsim.info/joust/
115 stars 19 forks source link

Switch to number maps for tags #166

Open beheh opened 7 years ago

beheh commented 7 years ago

We're currently using Immutable.Map<string, number> for tag maps. This was chosen because I noticed in Joust's early development that a Immutable.Map<number, number> was losing tags. This was probably a bug in Immutable.js. We should retest this and, if it's still an issue, file an upstream bug.

This should get rid of the various tags.set("" + GameTag.SOMETHING, 42) and make them a nice and clean tag.set(GameTag.SOMETHING, 42).

beheh commented 7 years ago

Hm, we, might not do this after all, since string keys are ubiqutious.