search

HearthSim / Joust

🍿 Hearthstone replays in your browser.
https://hearthsim.info/joust/
115 stars 19 forks source link

Fixes master build #216

Closed dzannotti closed 6 years ago

dzannotti commented 6 years ago

As result of my previous PR, master build/deployment fails This fixes:

internal/streams/legacy.js:59
      throw er; // Unhandled stream error in pipe.
      ^
Error: /Users/dzannotti/code/Joust/ts/debug.tsx
(4,27): error TS2307: Cannot find module 'electron'.

I'm not sure if it's a typescript requirement or what else webpack config doesn't include debug.tsx but none the less tscompiler is compiling debug.tsx which is looking for a devDep. This fixes it but i am unsure if the effort should be in keeping electron as devDep and exclude debug.tsx from deployment compilation

beheh commented 6 years ago

Yeah, not sure what's going on there. For now I'm happy with merging this to fix the deploy, but long term we'll probably just have to rewrite the webpack config (and actually just have two real configs for dev/prop, instead of gulpfile overriding keys for prod builds).