search

HearthSim / Joust

🍿 Hearthstone replays in your browser.
https://hearthsim.info/joust/
115 stars 19 forks source link

Fully implement pluralization (language rule 4) #221

Open jleclanche opened 6 years ago

jleclanche commented 6 years ago

Followup on #220. The text no longer looks weird, but pluralization is incorrect.

Until this is fixed we will be incorrectly displaying the text of some cards in some languages, such as Swipe in French.

Note: Unlikely to happen in Joust. I suspect we'll do it in Sunwell and by the time we do it, we'll switch to that.

joolean commented 6 years ago

@jleclanche Can you clarify what the work to be done here is?

jleclanche commented 6 years ago

This ticket is to implement card pluralization rules (|4 ...) which right now, althought they're parsed in Joust, they don't actually pluralize correctly (we don't bother parsing the number, we always assume it's plural IIRC).

The most likely fix is to switch to Sunwell for card rendering, which does have it implemented.

joolean commented 6 years ago

My understanding was the Sunwell was too slow to use in Joust. Has that changed?

jleclanche commented 6 years ago

It has not. There's a lot of performance work to do before we can use one inside the other.

joolean commented 6 years ago

In that case, I think we should fix this in Joust, running the risk that the work is rendered unnecessary if we for some reason prioritize Sunwell performance improvements.

jleclanche commented 6 years ago

I'm fine with that