Open jleclanche opened 6 years ago
@jleclanche Can you clarify what the work to be done here is?
This ticket is to implement card pluralization rules (|4 ...
) which right now, althought they're parsed in Joust, they don't actually pluralize correctly (we don't bother parsing the number, we always assume it's plural IIRC).
The most likely fix is to switch to Sunwell for card rendering, which does have it implemented.
My understanding was the Sunwell was too slow to use in Joust. Has that changed?
It has not. There's a lot of performance work to do before we can use one inside the other.
In that case, I think we should fix this in Joust, running the risk that the work is rendered unnecessary if we for some reason prioritize Sunwell performance improvements.
I'm fine with that
Followup on #220. The text no longer looks weird, but pluralization is incorrect.
Until this is fixed we will be incorrectly displaying the text of some cards in some languages, such as Swipe in French.
Note: Unlikely to happen in Joust. I suspect we'll do it in Sunwell and by the time we do it, we'll switch to that.