search

HearthSim / LotusTracker

Deck Tracker for Magic Arena [DEPRECATED]
https://www.mtglotusvalley.com/lotustracker
GNU Lesser General Public License v3.0
50 stars 10 forks source link

Fix missing "new" tag in lt_app_start metric #110

Closed beheh closed 5 years ago

beheh commented 5 years ago

As reading APP_SETTINGS->isFirstRun clears the new first run itself, all subsequent calls will always return false. This PR ensures that we locally store the first run state in order to correctly set the "new" tag on the lt_app_start metric.

This should fix Influx not recording a single instance of a "new" install in the last week.

I have not compiled or tested this yet.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.