search

HearthSim / UnityPack

Python deserialization library for Unity3D Asset format
https://hearthsim.info/
MIT License
720 stars 153 forks source link

Fix off-by-one error for 2019.4 bundles #101

Closed stevenvergenz closed 4 years ago

stevenvergenz commented 4 years ago

Each type tree in Unity 2019.4 (format 21) has an extra 4 bytes at the end compared to Unity 2019.1 (format 19), whose purpose is unknown. This PR consumes these 4 bytes so they don't cascade into bad offsets for the rest of the parse.

multimeric commented 4 years ago

Ah, great fix. It solved the bug I was encountering. Now if only it could be merged...

beheh commented 4 years ago

Hi there @stevenvergenz, thanks for your PR! All contributions to HearthSim require a signed CLA. I've sent you an invite to the repository, please follow the instructions there. If you've already signed the CLA, please let us know.

Once that's done and the CLA has been merged, we'll try to get this merged here as soon as possible.

stevenvergenz commented 4 years ago

Signed: https://github.com/HearthSim/cla/pull/41

beheh commented 4 years ago

Great, thank you!