search

HearthSim / decrunch

Python wrapper around Crunch DXTc decompressor
https://hearthsim.info
zlib License
14 stars 23 forks source link

Problem installing on MacOS #13

Open Hoishin opened 5 years ago

Hoishin commented 5 years ago 
In file included from crn_decomp.cpp:18:
crunch/crn_decomp.h:345:10: fatal error: 'malloc.h' file not found
#include <malloc.h>
         ^~~~~~~~~~
1 error generated.
error: command 'clang' failed with exit status 1

The problem seems to be introduced in this commit: https://github.com/HearthSim/decrunch/commit/6a21030f86fda86dd7c8bf51cfbab49a23487973#diff-99f7629e865e431d7ed8dd43d1f21ba5L345

Is it intentional?

jleclanche commented 5 years ago

Probably not, it was rebased. Can you submit a PR fixing the issue for you please?

Also if you want to prevent this from happening again I'd love a PR that adds macOS builds on travis.

macgregor commented 4 years ago

I was able to work around this but creating a symlink to the proper malloc header: sudo ln -s /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/malloc/malloc.h /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/malloc.h