HearthSim / hs-bugs

Unofficial Hearthstone issue tracker
https://hearthsim.info
65 stars 3 forks source link

Captain Blackheart's Treasure: The brawl's "discover" effect sometimes gives you duplicate card choices #267

Open Xinhuan opened 8 years ago

Xinhuan commented 8 years ago

https://twitter.com/ywoo_dev/status/667091159299174401

Confirmed to be a bug by Yong Woo.

jleclanche commented 8 years ago

Yeah I saw that too. So does this mean the brawl's discover is not a real discover?

PattuX commented 8 years ago

4.1: jv2ifva

Xinhuan commented 8 years ago

After watching a lot of screenshots and videos and playing the Brawl myself, I've come to the conclusion that the three choices offered in this Brawl are always in the order "Spell - Minion - Minion". Weapons are not offered in this Brawl. Since it is not a standard Discover effect, It is possible for the 2 offered minions to be duplicate minions.

Here is a link to Kripp's video of the Tavern Brawl, where in the first match, he is extremely surprised that the opponent Shaman managed to Discover something like 10 spells in a row: https://www.youtube.com/watch?v=XXvl1FTmkxM

It is not possible to deduce if your opponent picked a spell or a minion because the displayed choices for your opponent are randomized. (However, I did not check if there is info-leak in the logs based on the creation order of their entityID as is the case for Rafaam's artifacts - Issue #345).

If your hero is replaced with Ragnaros, the first two choices are minions. It is unclear what the third choice (on the right) can be, but the non-collectible 2/3 vanilla Pirate can be offered in that slot, along with an Excavated Evil that was shuffled earlier into the player's deck: https://www.reddit.com/r/hearthstone/comments/423g88/discover_brawl_and_ragnaros_appear_to_have_an/

This leads to the speculation that the third slot might be a card that is remaining in your deck.

PattuX commented 8 years ago

If you're in fatigue as Ragnaros, you will only get offered 2 cards (with proof):

https://www.reddit.com/r/hearthstone/comments/42b2os/so_this_is_what_happens_when_you_try_to_discover/

No matter, whether you pick the card offered from your deck, it will removed from deck. Strangely, the Zone of all 3 choices is DECK when offered. (Hand/Setaside after picking)

Sidenote: Jaraxxus always offers you Warlock cards.

Also the spell has the highest id among the 3 choices, so I guess that's an info-leak. You may decide whether it's worth opening another issue.

Xinhuan commented 8 years ago

The OP directly contradicted you: "If you don't pick the pirate (or the card drawn from your deck) your deck does not deplete."

PattuX commented 8 years ago

Unfortunatelly, I didn't take any proof, but @culinko can confirm.

culinko commented 8 years ago

The card is already subtracted from your deck when being presented with the 3 choices at the start of the turn. Does not matter if you pick it or not, it's already gone from the deck. We specifically checked that. No screenshots, though.

Xinhuan commented 8 years ago

Pattux and culinko are correct.

Added video proof - https://www.youtube.com/watch?v=5Mhvjjp8euY And logs - https://gist.github.com/Xinhuan/00991bc69e727cf914c6

The start of turn "Discover" effect is the same one used by the Hunter spell Tracking. At the start of turn, the game inserts at the top of your deck 3 random cards and then "Tracks" those 3 cards for you via a trigger.

This is observable in the game logs where the cards are created in the DECK zone with ZONE_POSITION values of 1, 2 and 0. The cards are then moved into SETASIDE to let you pick them (and their ZONE_POSITION all changes to 0). The 2 minions are created first followed by the spell, so the 2 minions are inserted at the start of the deck first, followed by the spell so that the spell becomes the first choice on the left when Tracked. This means the entityID of the spell is always the highest of the triplet and is an info-leak.

The logs look similar to the logs produced when Tracking is played (without the card creation). This also confirms that the Blackheart brawl is a precursor to the Discover effect released in LoE as the devs have mentioned that the idea for Discover came from this brawl.

if your hero is replaced by Ragnaros, the game is unable to find a neutral collectible spell and only inserts 2 minions in your deck. This results in the situation where the 3rd card offered at the start of turn is a random card from your deck, which can include cards shuffled into it from earlier in the game. Your deck size will always go down by 1 regardless of what choice you pick. As such, if you run out of cards in your deck as Ragnaros, the game only offers 2 cards to you.

Xinhuan commented 8 years ago

https://www.youtube.com/watch?v=ZLBMNjBmXRc https://gist.github.com/Xinhuan/b1970c6b33873e0d9482

The game respects the 60 card deck size limit when trying to insert these 3 cards at the start of the turn, so if you have a 60, 59 or 58 card deck, some or all of these card insertions fail and result in 3, 2 or 1 card being offered to you respectively from the top of your deck. In this video, the only minion in the deck is the 2/3 vanilla Pirate available only in the Tavern Brawl.

Patashu commented 8 years ago

This brawl came back, and a user is reporting that they hanged at the start of their turn as Ragnaros:

https://www.reddit.com/r/hearthstone/comments/4zdfw6/becoming_ragnaros_in_the_new_tavern_brawl_is/

This weird thing happened too with minions turning invisible: https://www.reddit.com/r/hearthstone/comments/4zdfw6/becoming_ragnaros_in_the_new_tavern_brawl_is/d6v5t57