Bad HTML in the descriptions of some Old Gods cards

HearthSim / hs-bugs

Unofficial Hearthstone issue tracker

https://hearthsim.info

65 stars 3 forks source link

Bad HTML in the descriptions of some Old Gods cards #459

Open jleclanche opened 8 years ago

jleclanche commented 8 years ago

Duplicate bold tags present.

Cult Sorcerer (OG_303):

[x]&lt;b&gt;&lt;b&gt;Spell Damage&lt;/b&gt; +1&lt;/b&gt;
After you cast a spell,
give your C'Thun +1/+1
&lt;i&gt;(wherever it is).&lt;/i&gt;

Twin Emperor Vek'lor (OG_131):

[x]&lt;b&gt;&lt;b&gt;Taunt&lt;/b&gt;
Battlecry:&lt;/b&gt; If your C'Thun has
at least 10 Attack, summon
another Emperor.

The issue is only present in English.

Ack'd here: https://twitter.com/ywoo_dev/status/724806306175938560

troggnostupidhs commented 7 years ago

Is this fixed?

https://api.hearthstonejson.com/v1/15590/enUS/cards.json

"text":"[x]Spell Damage +1\nAfter you cast a spell,\ngive your C'Thun +1/+1\n(wherever it is)."

"text" : "[x]Taunt\nBattlecry: If your C'Thun has\nat least 10 Attack, summon\nanother Emperor."

jleclanche commented 7 years ago

It's not fixed no

troggnostupidhs commented 7 years ago

is the issue that there are two opening  tags at the start of the text?

jleclanche commented 7 years ago

Yes.

troggnostupidhs commented 6 years ago

I would like to bring this up again as valid html

https://validator.w3.org/#validate_by_input

<!DOCTYPE html>
<html lang="en">
<head><title>text</title></head>
<body>
<b><b>Taunt</b>\nBattlecry:</b>
</body>
</html>

jleclanche commented 6 years ago

That it's valid html5 doesn't make it correct to use. html5 is extremely lenient. I'm also saying "html" loosely; it happens to use html tags for bold/italic but it's a stripped down markup.

troggnostupidhs commented 6 years ago

https://stackoverflow.com/a/22186981

It's not invalid markup to have nested b elements, but there is no definitive answer to what nested b elements would actually mean.

That answer cites the html spec and says that nested should be fine (and mentions that the b tag itself is problematic in general).

  should be nested correctly.

jleclanche commented 6 years ago

Again, that's really not the point. Whether it's semantically valid is irrelevant.

troggnostupidhs commented 6 years ago

What is the point of this ticket?