Out of memory error and so on

[jcrka]

Downloaded and tried, all worked smooth until OOM occured after approx 2 hours online.

Crittical

1. Out of memory error

It wrote "Hearthstone window with process name Hearthstone.exe closed" But it wasn't, it was an OutOfMemoryException in the log.txt. After that application simply lost its mind, it couldn't neither create socket, nor save config.ini, and after restart it deleted old log,

1.1. Where to set -Xmx in your distribution ?

1.2. Stacktraces are lost :( on uploader restart, i guess is better to setup RollingFileAppender in logback

Normal

1. If other player instantly surrender and you start new game, program still think that u r playing with previous player and misses that 1st instant win. May be i started new too fast, but don't think so. Anyway it doesn't detect class change (1st player was druid, new mage and program still had druid in Current Match tab).

Cosmetic

3. Russian nicknames doesn't read by OCR

System environment: 21:16:26.576 [ main] INFO net.hearthstats.Main - ** 21:16:26.579 [ main] INFO net.hearthstats.Main - Starting HearthStats.net Uploader 0.16.1 on WINDOWS 21:16:26.581 [ main] INFO net.hearthstats.Main - os.name=Windows 7 21:16:26.581 [ main] INFO net.hearthstats.Main - os.version=6.1 21:16:26.581 [ main] INFO net.hearthstats.Main - os.arch=x86 21:16:26.581 [ main] INFO net.hearthstats.Main - java.runtime.version=1.7.0_55-b14 21:16:26.581 [ main] INFO net.hearthstats.Main - java.class.path=E:\Hearthstats\HearthStats.exe 21:16:26.581 [ main] INFO net.hearthstats.Main - user.language=en 21:16:26.581 [ main] INFO net.hearthstats.Main - **

[gtch]

Thanks for the report. I've seen a few other people experience out of memory errors on Windows recently (for example #264). I suspect a memory leak in the native code which might take me a while to track down, so I'm going to release a new build with a higher memory limit until I find it.

We set -Xmx directly during the build to -Xmx192m. As I said I'm about to increase that, but if you want to try yourself you could try creating a HearthStats.l4j.ini file as described in http://launch4j.sourceforge.net/docs.html#Additional_jvm_options — I haven't tried it myself, but it might be useful until I get the new release out later today.

[gtch]

Also — an image of your opponent's name is saved in the tmp folder as opponentname.png. If you see a Russian name, attach that image here and we can start to build support for Russian names (we need several images to train the OCR with).

[jcrka]

HearthStats.l4j.ini is working, checked

Also — an image of your opponent's name is saved in the tmp folder as opponentname.png.

Ок, i changed source code, so it keeps all opponentname.png on my hard drive, so if i "fish" some russian battletags i'll submit pngs and utf-8 texts.

[jcrka]

btw, where to send/upload a net/hearthstats/resources/Main_ru.properties file ?

not a git user :( (svn)

[gtch]

Thanks! If you don't want to use git, just paste Main_ru.properties into a site like http://pastebin.com and then post a link to it here.

[jcrka]

http://pastebin.com/e5Hw3eSS

git maybe later, atm really have no time to install it and learn how to branch, where and when to commit etc

[gtch]

Thanks @jcrka! I've included your Russian translation in the v0.17 release.