HearthStats / HearthStats.net-Uploader

Auto uploader for HearthStats.net
BSD 3-Clause "New" or "Revised" License
123 stars 54 forks source link

Made video showing everything I notice that is broken on mac [20.0 version] #526

Open ltuzia opened 10 years ago

ltuzia commented 10 years ago

I made video of the broken detection of decks because it was so far off that I thought no one would believe me that it is this broken without proof (lol). Then while I was recording that I had an idea that I should just record everything that is broken that I have noticed in other tickets so that maybe it can be fixed sooner.

Unfortunately in the example game I ended up in a priest vs. priest matchup so the match is very long. I guess just use 2x speed for the middle part of the video (sorry).

Here is a brief overview of everything that is seen in the video:

Video link: http://youtu.be/I4vtdOEgCIM

(Below is just talk about the exporting bug)

Here are some images of my decks and what it ended up thinking my deck list was.

screen shot 2014-09-08 at 20 41 53

1 Blessing of Wisdom 1 Ice Lance 1 Equality 2 Slam 1 Ironbeak Owl 1 Wild Pyromancer 1 Dancing Swords 1 Truesilver Champion 1 Consecration 1 Soul of the Forest 1 Chillwind Yeti 1 Faceless Manipulator 1 Fen Creeper 1 Lord of the Arena

screen shot 2014-09-08 at 21 07 04

1 Circle of Healing 1 Slam 1 Ironbeak Owl 1 Wild Pyromancer 2 Kill Command 1 King Mukla 1 Mind Control Tech 2 Auchenai Soulpriest 1 Dragonling Mechanic 1 Lightspawn 1 Mogu'shan Warden 1 Faceless Manipulator 1 Holy Fire 1 Lay on Hands

screen shot 2014-09-08 at 21 08 26

1 Arcane Missiles 1 Shield Slam 1 Mana Wyrm 1 Mind Blast 1 Slam 1 Animal Companion 1 Kill Command 1 Kirin Tor Mage 1 Mind Control Tech 1 Polymorph 1 Water Elemental 1 Faceless Manipulator 1 Sylvanas Windrunner 1 Ancient of Lore

tyrcho commented 10 years ago

Wow that's a log of bugs :-s Thanks for the detailed report !!

Some of the bugs seem to be related to the resolution, what is the resolution you are using Hearthstone with ? I think we probably don't test enough in the lower resolutions.

ltuzia commented 10 years ago

No problem! 1024 x 768 (the smallest one)

It used to work perfectly fine. It stopped recording a few versions ago when hearthstats was updated for naxx adventures.

This is my post from then: https://github.com/HearthStats/HearthStats.net-Uploader/issues/494

gtch commented 10 years ago

Thanks for the video — the 1024x768 resolution is definitely a factor, because we tend to test with larger sizes. However it should work at 1024x768 and I'm surprised that so little is working.

Judging by the video, I'm guessing you are running it on an 13-inch MacBook. Is it a Retina display? If so, that could be the explanation of the problem... Hearthstone doubles its pixels on Retina displays instead of running at native resolution, and that causes some problems for the screen captures used for detection. I have access to a 13" Retina MacBook Pro that I could use to investigate these problems, so tell me if your display is Retina...

ltuzia commented 10 years ago

I don't know if it is retina. It is a 13 inch early 2011 macbook pro. It's running 10.9.4 (I don't what name that is. I think it is the newest mac os)? If that is not enough information to know if it is retina, do you know where I look in the settings to find the answer?

gtch commented 10 years ago

If it's 2011 then I don't think it's Retina, but you can check by going to the 'About This Mac' item on the Apple menu, then click 'More Info'. If it says "Retina 13-inch" on the model name like this screenshot then it's Retina... if just says "13-inch" then it's not Retina...

Retina

ltuzia commented 10 years ago

Thank you! It is not retina (That is how I find the year information).

I copy the other information:

Processor 2.7 GHz Intel Core i7 Memory 4 GB 1333 MHz DDR3 Graphics Intel HD Graphics 3000 384 MB

kidkerrigan commented 10 years ago

Hey all! Just signed up to say that I saw the same errors when exporting my decks. I first noticed it because I was trying to export a deck and it gave an error saying that there were only 29 cards in the deck and it needed 30: image

Here's the true deck list (you can see it has 30/30 cards): image

And here's what it tried to export: 2 Hunter's Mark 1 Silence 2 Flare 2 Leper Gnome 1 Timber Wolf 2 Undertaker 2 Webspinner 1 Explosive Trap 1 Freezing Trap 1 Misdirection 2 Haunted Creeper 1 Knife Juggler 2 Starving Buzzard 2 Eaglehorn Bow 2 Animal Companion 1 Kill Command 2 Unleash the Hounds 1 Houndmaster 1 Savannah Highmane

My specs FYI: image image

Hope that helps! I'm actually very excited about this feature and was suprised it got added so fast :) It'll make it a lot easier to upload new deck versions when they're tweaked. The names of the decks usually come out garbled as well.

Good luck! Thank you so much for all the effort making this tool - it helps to see my progress even though I'm not the best player.