search

HearthStats / hearthstats

Details Hearthstone match statistics and tracking.
hearthstats.net
Other
88 stars 44 forks source link

Added player names to to matches page #450

Closed jspri closed 9 years ago

jspri commented 9 years ago

As per #449

jspri commented 9 years ago

The tabs didnt appear the same as my editor, I'll fix that

jspri commented 9 years ago

I think the scraped name may be better incase there are inconcsistensies between that and the log it shows on the page. I assume it needs logic to check that @players and @match.oppname exist? If they dont it could default to the profile name.

trigun0x2 commented 9 years ago

@Crazometer it should be the same because the app gets the player names from the log. The problem here is that sometimes another app such as HDT also uploads to HearthStats but we would not have the log file. When this happens, you would have to add another fallback check.

It'll be easier just to use the oppname and profile.name.

jspri commented 9 years ago

Swapped it around, I think it should be good to go now?

trigun0x2 commented 9 years ago

@Crazometer looks good!