Refactor and add test coverage to get_type_popularity

HearthStats / hearthstats

Details Hearthstone match statistics and tracking.

hearthstats.net

Other

88 stars 44 forks source link

Refactor and add test coverage to get_type_popularity #498

Closed crawsible closed 9 years ago

crawsible commented 9 years ago

Hi, HearthStats!

In this PR, I added some low-level integration test coverage around the ::get_type_popularity class method of UniqueDeckType, and then refactored it to move the filtering logic into the SQL query for performance. Hope this helps!

-csj