HeartofPhos / exile-leveling

Path of Exile Leveling Guide
https://HeartofPhos.github.io/exile-leveling/
159 stars 31 forks source link

Add toggle to display gems only #56

Closed ennukee closed 1 year ago

ennukee commented 1 year ago

Mimics a lot of logic from #55 by MonteePoke, but with some additional logic needed for this toggle to live in the build tab for proper config purposes

User flow

This use case is primarily for those who know acts well already, but may not have perfect knowledge of when and where to buy every gem they made need for their build while leveling

MonteePoke commented 1 year ago

Без названия (6)

ennukee commented 1 year ago

If you want to copy the config logic from this PR back to your own I'd be ok closing this PR. Wasn't sure how quickly it'd be responded to and it'd be great to have this in before league launch if possible :)

MonteePoke commented 1 year ago

Nah, you can just pull my commit... i guess? Not used to dealing with forks

ennukee commented 1 year ago

OK, I think I've integrated your code into mine. Not used to working with forks either, that was a bit weird to do, but I see your commits in the commit list for this PR now so I think it worked (honestly didn't think I could merge in a separate fork's code or I probably would've done that to start with)

MonteePoke commented 1 year ago

Thanks 🤝

HeartofPhos commented 1 year ago

Generally happy with the idea, would like to adjust the implementation slightly, @ennukee do you mind giving me write access to this branch?

HeartofPhos commented 1 year ago

Ok, moved the logic into recoil state and filter before injecting the gem steps I'll add the package.json script updates in a separate commit, makes perfect sense just want to keep concerns separated

Happy to merge as is, let me know if there's anything else still pending

MonteePoke commented 1 year ago

Wanted to look into starting beach gems, but it obviously will go in separate pr Lgtm

HeartofPhos commented 1 year ago

Wanted to look into starting beach gems, but it obviously will go in separate pr Lgtm

Been meaning to look at this eventually believe it can be datamined, happy to discuss in an issue

MonteePoke commented 1 year ago

Datamined? I was talking about gems like Double Strike and Chance to Bleed for Duelist and so on... Wait, it already does take it into consideration? My build just has 2 Chance to Bleed supports...

HeartofPhos commented 1 year ago

Yes I believe the gems each class receives can be data mined (so I don't have to manually update things) just need to get around to actually looking at it.

At the moment it's not catered for at all any build that has starter/chest gems in the POB will be asked to buy them at Nessa

ennukee commented 1 year ago

Thanks for all the discussion, turns out our timezones are probably a bit inverted 🙂. In regards to datamining, is that something you plan to do for the new supports / new purchase location of supports in 3.21 when patching comes up? For example, Sniper's Mark will now be accessible at Level 4, but the gem layout still says to buy it in Act 2 like in 3.20.