HeartofPhos / exile-leveling

Path of Exile Leveling Guide
https://HeartofPhos.github.io/exile-leveling/
159 stars 31 forks source link

Search only shows single string when using # #85

Closed gorsech closed 1 year ago

gorsech commented 1 year ago

Looks like a new bug surfaced with the search string. Could be related to https://github.com/HeartofPhos/exile-leveling/pull/80

Adding the # character to a string will only show that string in the search sidebar.

Missing a string:

CleanShot 2023-08-15 at 11 29 02

CleanShot 2023-08-15 at 11 29 08

Both strings visible as expected:

CleanShot 2023-08-15 at 11 39 09

CleanShot 2023-08-15 at 11 39 14

HeartofPhos commented 1 year ago

I reworked it a bit to be something more like "friendly name" as opposed "label" so in your first example clicking bbb|bbg would instead copy nne|rint to clipboard though in a more realistic scenario you'd likely do something like

#click for boots regex
nne|rint

to get image

Does that align with what you tried to accomplish with your PR?

gorsech commented 1 year ago

Ohh I see now, thanks for the clarification! That admittedly was not what I originally intended 😅 but this is honestly way better. Will close this one as done.