Heath123 / pakkit

MIT License
504 stars 27 forks source link

Not logging handshake and login start packets #65

Closed ninjadev64 closed 2 years ago

ninjadev64 commented 2 years ago

Not much else to say, it isn't logging handshake and login start packets sent to the server, my custom server detects and logs them so they are being sent through

Heath123 commented 2 years ago

Someone requested this before I think, but I can't find it. Anyway, the library I'm using abstracts this away, but I can probably find a way to make it report the login packets if you need this

ninjadev64 commented 2 years ago

That would be great, thanks - also could you make it log malformed packets? I'm writing a server and I'm trying to use this to see what I'm doing wrong with my status response packet.

ninjadev64 commented 2 years ago

The second bit about malformed packets is much more important (I'm good with the handshake and login, just was wondering why it didn't log them)

Heath123 commented 2 years ago

That would be great, thanks - also could you make it log malformed packets? I'm writing a server and I'm trying to use this to see what I'm doing wrong with my status response packet.

I think I implemented some level of basic support for this, but I'll need to make sure it still works because I probably broke it. Malformed packets will have to only be visible as hex, of course, because they can't be decoded

ninjadev64 commented 2 years ago

I think I implemented some level of basic support for this, but I'll need to make sure it still works because I probably broke it. Malformed packets will have to only be visible as hex, of course, because they can't be decoded

Yeah, of course

ninjadev64 commented 2 years ago

I think this was resolved a while ago, thanks