Falsely detects "online mode" when monitoring the connection between bungeecord and pandaspigot 1.8

[lax1dude]

Hi, I'm trying to determine why pandaspigot 1.8 is disconnecting bungeecord, or why bungeecord is disconnecting from pandaspigot 1.8, when I try to use a plugin I made for bungeecord that replaces most of the client-to-proxy network stack.

I'm trying to use this tool to see if I can catch what part of the proxy-to-server network stack's handshake is causing it to disconnect because I don't want to drive myself insane looking at wireshark hex dumps, but I get the "this server is online mode, please copy this code into your browser" message when I try to intercept the connection between bungeecord and pandaspigot.

Both bungeecord and pandaspigot have online-mode set to false.

The bug also happens when I try to connect to bungeecord using a vanilla client instead of my custom stack.

To reproduce, simply set up bungeecord and pandaspigot 1.8, monitor the connection between bungeecord and pandaspigot, and then connect to bungeecord with vanilla minecraft 1.8.

[lax1dude]

oops, spigot got disconnected because I forgot newer versions have a bungeecord config.yml boolean, didn't fix the bug though

[Alvinn8]

I had issues with pakkit detecting a 1.18.2 server as online mode when the server was offline mode. So this issue might not be specific to bungeecord and stuff

[wojtess]

Same for 1.17 purpur, cant join offline server

[Heath123]

Sort of fixed in https://github.com/Heath123/pakkit/commit/9698706b17252215d74ea3446104ee4839d2d888, but not really because I just turned off online mode properly. I need to fix the auto detection or add a toggle

[Hellscaped]

well hello lax, didnt expect to see you here.