search

HeatherComputer / AdvancedBackups

BSD 3-Clause "New" or "Revised" License
38 stars 7 forks source link

Bug report : if `world` directory is symlink, restore script deletes it #91

Open ja-cop opened 2 months ago

ja-cop commented 2 months ago

Describe the bug I usually put the world data on a different filesystem with more space than the filesystem with the rest of the server files. One way to do this is with a symlink, where world points to a different directory. The restore script seems to delete this symlink, create a regular directory and start filling it with files, which then runs out of space as the filesystem can't fit the world.

One workaround is to replace the symlink with a root-owned bind mount.

To Reproduce Use the restore script with the symlink setup.

Expected behavior The restore script would alter the contents of the world directory, but not the directory/link itself.

Versioning (please complete the following information):

Just wanted to add that with the workaround the restore worked well and was a big help to one of my players. Thanks for creating and sharing this mod! :slightly_smiling_face:

ja-cop commented 2 months ago

I also noticed that the restore script creates a clibackup_*.zip file in the root of the server files - fortunately I had enough space for this file, but maybe it would make sense to put this file in the backups directory?