search

Heatmanofurioso / ngx-avatars

Spiritual successor of HaithemMosbahi's ngx-avatar
MIT License
16 stars 11 forks source link

Update to Angular12 #19

Closed Heatmanofurioso closed 3 years ago

Heatmanofurioso commented 3 years ago

@PowerKiKi Would you give this a review please?

PowerKiKi commented 3 years ago

Sorry, I won't invest too much time on this anymore.

I only had a quick glance and noticed this will require rxjs 7. This might prevent usage for users who did not upgrade yet. I personally wouldn't care and do exactly what you did. But if you want to maximize adoption you might want to consider accepting both 6 and 7.

For the rest the lib is relatively well tested, so as long as it passes you should be good to go I guess.